From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28865 invoked by alias); 11 Feb 2020 14:57:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28855 invoked by uid 89); 11 Feb 2020 14:57:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=no version=3.3.1 spammy=a.m, UD:a.m X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.50.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Feb 2020 14:57:36 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 349053CA45 for ; Tue, 11 Feb 2020 08:56:33 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 1WxljMY1C8vkB1WxljKmKk; Tue, 11 Feb 2020 08:56:33 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qh/VJ5RV6+VGvbQWdfcjcGpsULqxS4Diqc+knwAw2/Q=; b=CsBxpJ10kvtq27f+SLyZUik/X+ 7XUKFH/2vGCQO4TPdO2Il2Mxz6jeyClNs/+sOVL3g0LvCQl5alWzGJpolP3NUH3AH725JFLloTEQK ln51MYceRlOWaY75ZuOXbzftE; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:50016 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j1Wxk-001tS5-Tw; Tue, 11 Feb 2020 07:56:32 -0700 From: Tom Tromey To: Simon Marchi Cc: Christian Biesinger , gdb-patches Subject: Re: [PATCH 3/3] Add -Wstrict-null-sentinel to gdbsupport/warning.m4 References: <20200210164024.32445-1-simon.marchi@efficios.com> <20200210164024.32445-3-simon.marchi@efficios.com> Date: Tue, 11 Feb 2020 14:57:00 -0000 In-Reply-To: (Simon Marchi's message of "Mon, 10 Feb 2020 11:46:28 -0500") Message-ID: <87a75pdvfj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00389.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> On 2020-02-10 11:42 a.m., Christian Biesinger wrote: >> Any thoughts on instead dong: >> +-Wstrict-null-sentinel \ >> +" >> >> so that future changes don't need to change the last line? Helps with blame too. Simon> Sure, I I'll do that. I like when we use a comma after the last enumerator in enums Simon> too, for the same reason. Me too. Thanks for doing this. I should have more mail this morning before writing this same patch :-) This looks good, please check it all in. Tom