From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14974 invoked by alias); 28 Feb 2020 16:08:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14966 invoked by uid 89); 28 Feb 2020 16:08:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*i:sk:871rqek, H*f:sk:871rqek X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-1.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (207.211.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Feb 2020 16:08:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582906131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W46GTRf28/Yeph5SDSKVH1GLEvU/BtoqghSNdmAoZmY=; b=bxHgViYX2zZQdsw2cTYQLbbF2nUCbjFI9PhOx+F3oJvgjWI4W6QI/VHDEabz6wxNsH6y/X 4/7qwW2ILA/g1TxhO77Y4HH91ucczZMLVeWdslB0ClK83iapN0QXn5ZQu/fBXrPdEyJAeZ uKZYN3YoWn2I3TErdjnmkVB0r5IcfZo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-153-xoqnLCUBNl22t7zJvncuWw-1; Fri, 28 Feb 2020 11:08:48 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C69B48010F0; Fri, 28 Feb 2020 16:08:46 +0000 (UTC) Received: from localhost (unused-10-15-17-54.yyz.redhat.com [10.15.17.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 98B925DA75; Fri, 28 Feb 2020 16:08:46 +0000 (UTC) From: Sergio Durigan Junior To: Tom Tromey Cc: GDB Patches , Pedro Alves , Eli Zaretskii , Ruslan Kabatsayev Subject: Re: [PATCH 1/6] Introduce scoped_pipe.h References: <20190926042155.31481-1-sergiodj@redhat.com> <20200226200542.746617-1-sergiodj@redhat.com> <20200226200542.746617-2-sergiodj@redhat.com> <871rqeka6p.fsf@tromey.com> Date: Fri, 28 Feb 2020 16:08:00 -0000 In-Reply-To: <871rqeka6p.fsf@tromey.com> (Tom Tromey's message of "Fri, 28 Feb 2020 08:23:26 -0700") Message-ID: <87a752r8xd.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg01061.txt.bz2 On Friday, February 28 2020, Tom Tromey wrote: >>>>>> "Sergio" =3D=3D Sergio Durigan Junior writes: > > Sergio> gdb/ChangeLog: > Sergio> yyyy-mm-dd Sergio Durigan Junior > > Sergio> * unittests/scoped_pipe-selftests.c: New file. > > Sergio> gdbsupport/ChangeLog: > Sergio> yyyy-mm-dd Sergio Durigan Junior > > Sergio> * scoped_pipe.h: New file. > > I think new general-purpose code should go in gdbsupport. Yep. scoped_pipe.h is there. > Unfortunately right now we don't have a good way to put the unit tests > there. This is something we ought to do eventually though. Right, that's something I noticed as well. > Sergio> +#ifndef COMMON_SCOPED_PIPE_H > > I think we've been using GDBSUPPORT rather than COMMON now. Ah, OK. I found other places using COMMON, but I'll change it here. > Sergio> + explicit scoped_pipe () > > I think explicit is only needed for 1-arg constructors. OK, I'll remove the keyword. I'll make the changes locally. Thanks, --=20 Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/