From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway21.websitewelcome.com (gateway21.websitewelcome.com [192.185.45.210]) by sourceware.org (Postfix) with ESMTPS id 81C9C385DC00 for ; Sat, 4 Apr 2020 14:05:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 81C9C385DC00 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway21.websitewelcome.com (Postfix) with ESMTP id B9E32400D87B0 for ; Sat, 4 Apr 2020 09:05:01 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id KjPxj2XAeXVkQKjPxjGoTU; Sat, 04 Apr 2020 09:05:01 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nnd0a5jxK+CLud8O29ILFJoCR+OzM1KAeQqNiWpUHu0=; b=muaeDvJf34Vhqw53yVtv4qHQiA FnxoPrRDj1/S3e89SK9EnuEL6sTOA/k9xeYZNTaIuJiB2VXd4m6vqBX/QhC/iG8bAC2MuG2yqHj+a sKtpOJfdqEBjDCrSywzkjkWNZ; Received: from 174-16-110-145.hlrn.qwest.net ([174.16.110.145]:52914 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jKjPx-003N5P-H3; Sat, 04 Apr 2020 08:05:01 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 12/20] Remove DW_ADDR References: <20200328192208.11324-1-tom@tromey.com> <20200328192208.11324-13-tom@tromey.com> X-Attribution: Tom Date: Sat, 04 Apr 2020 08:05:00 -0600 In-Reply-To: (Simon Marchi's message of "Mon, 30 Mar 2020 11:40:33 -0400") Message-ID: <87a73rtkhf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.110.145 X-Source-L: No X-Exim-ID: 1jKjPx-003N5P-H3 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-110-145.hlrn.qwest.net (bapiya) [174.16.110.145]:52914 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Apr 2020 14:05:04 -0000 >>>>> "Simon" == Simon Marchi writes: Simon> I wonder if we should assert Simon> gdb_assert (!requires_reprocessing); Simon> in attribute::address and attribute::string. Otherwise, we could miss Simon> reprocessing an attribute and we'd return a bogus value, it seems. Makes sense, I did this. Tom