From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [50.116.125.2]) by sourceware.org (Postfix) with ESMTPS id 7E12E388B02E for ; Fri, 22 May 2020 21:04:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7E12E388B02E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 01917401035BA for ; Fri, 22 May 2020 15:24:31 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cEqbjcrNiVQh0cEqbjg62G; Fri, 22 May 2020 16:04:53 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NzcTZEZLRqHu5qgAmCUDa++ULk5hh4acMgpHtyEpGJE=; b=j1ZMJ+BMSPVB6jBJA7HV9D8maX oxRkRDOo3TpYf3P+aEcpD3TbKKtamtKgdsyu3A6LutvEugwLAPUir7KHTH8zGDAFC8xTc68x7VTDj 82rf079jilprAAcHO4gMcTI6T; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:36252 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jcEqa-004DVQ-Oz; Fri, 22 May 2020 15:04:52 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH v2 23/42] Add dwarf2_per_objfile to dwarf_expr_context and dwarf2_frame_cache References: <20200512210913.5593-1-simon.marchi@efficios.com> <20200512211250.6230-24-simon.marchi@efficios.com> X-Attribution: Tom Date: Fri, 22 May 2020 15:04:51 -0600 In-Reply-To: <20200512211250.6230-24-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Tue, 12 May 2020 17:12:31 -0400") Message-ID: <87a71z1y18.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jcEqa-004DVQ-Oz X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:36252 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2020 21:04:55 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> *Note*, there's one spot I'm particularly unsure about. In Simon> dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value, we would save and Simon> overwrite the offset value in the context, along with a bunch of other Simon> state. This is because we might be about to evaluate something in a Simon> different CU that the current one. If the two CUs are in the same Simon> objfile, then the text_offset is the same, as it's a property of the Simon> objfile. However, if the two CUs are possibly in different objfiles, Simon> then it means the text_offsets are different. It would also mean we Simon> would need to save and restore the dwarf2_per_objfile in the context. Simon> Is that even possible? Unfortunately I don't know for sure. However, call_site_for_pc doesn't distinguish between objfiles. So, I suppose I would assume it is possible. Tom