From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/symtab] Implement addrmap_mutable_find
Date: Wed, 04 Aug 2021 10:18:21 -0600 [thread overview]
Message-ID: <87a6lx5gky.fsf@tromey.com> (raw)
In-Reply-To: <20210803144656.GA8040@delia> (Tom de Vries's message of "Tue, 3 Aug 2021 16:46:58 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> Currently addrmap_mutable_find is not implemented:
Tom> ...
Tom> static void *
Tom> addrmap_mutable_find (struct addrmap *self, CORE_ADDR addr)
Tom> {
Tom> /* Not needed yet. */
Tom> internal_error (__FILE__, __LINE__,
Tom> _("addrmap_find is not implemented yet "
Tom> "for mutable addrmaps"));
Tom> }
Tom> ...
Tom> I implemented this because I needed this during debugging, to be able to do:
Nice. I also needed this for my DWARF scanner rewrite.
My approach was slightly simpler, but yours has asserts, so is probably
preferable. Anyway it looks fine to me.
Tom
prev parent reply other threads:[~2021-08-04 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 14:46 Tom de Vries
2021-08-04 10:57 ` [committed][PATCH][gdb/symtab] " Tom de Vries
2021-08-04 16:18 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6lx5gky.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox