From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6PpiI0HBTGGSHAAAWB0awg (envelope-from ) for ; Thu, 23 Sep 2021 14:02:41 -0400 Received: by simark.ca (Postfix, from userid 112) id 7F18D1EE25; Thu, 23 Sep 2021 14:02:41 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BD8161EDF7 for ; Thu, 23 Sep 2021 14:02:40 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 258DE3857C4A for ; Thu, 23 Sep 2021 18:02:40 +0000 (GMT) Received: from gateway21.websitewelcome.com (gateway21.websitewelcome.com [192.185.45.91]) by sourceware.org (Postfix) with ESMTPS id 97E4F3858D29 for ; Thu, 23 Sep 2021 18:01:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 97E4F3858D29 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 034D2400CB9AB for ; Thu, 23 Sep 2021 13:01:45 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id TT2WmeaPmjSwzTT2Wm7z0P; Thu, 23 Sep 2021 13:01:45 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=pXJozclessVIUzwGHqKl+C4b0gp6DzevvbQFZ/WzSjM=; b=qZBJ1b3lhlFU8jtgB1fovNVh3y YO9wV9WWEoyaV85QYS0k9ORgNNMZlVOEKAfAkLk2w5ggrwlMsnwd6mJKD020Jh5/qmMJ9sLHXKNgC VXu55MkQBy5lEIttq4tpZu/MZ; Received: from 174-16-0-219.hlrn.qwest.net ([174.16.0.219]:53900 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mTT2W-000zTf-FJ; Thu, 23 Sep 2021 12:01:44 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Subject: Re: [PATCH][gdb/testsuite] Support -fPIE/-fno-PIE/-pie/-no-pie in gdb_compile_rust References: <20210922090715.GA6660@delia> X-Attribution: Tom Date: Thu, 23 Sep 2021 12:01:43 -0600 In-Reply-To: <20210922090715.GA6660@delia> (Tom de Vries via Gdb-patches's message of "Wed, 22 Sep 2021 11:07:20 +0200") Message-ID: <87a6k35fy0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.0.219 X-Source-L: No X-Exim-ID: 1mTT2W-000zTf-FJ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-0-219.hlrn.qwest.net (murgatroyd) [174.16.0.219]:53900 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> Fix this by translating the gcc options to rustc options in gdb_compile_rust, Tom> similar to how that is done for ada in target_compile_ada_from_dir. Thanks for doing this. Tom> + global board Tom> + set board [target_info name] Tom> + set multilib_flags_orig [board_info $board multilib_flags] Tom> + set multilib_flags "" Tom> + foreach op $multilib_flags_orig { This iterates over the flags as if they are a list, but constructs the new flags as if it is a string: Tom> + append multilib_flags " -C link-arg=$op" This could in principle cause some quoting issues, though in practice this would only occur with relatively weird values. If that's a concern, a fix would be to use: set multilib_flags {} ;# this is more idiomatic, not critical ... lappend multilib_flags -C link-arg=$op Other than this, this seems fine to me. Maybe even fine as-is, up to you. Tom