From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SOgBAMW8VmMBIRAAWB0awg (envelope-from ) for ; Mon, 24 Oct 2022 12:26:45 -0400 Received: by simark.ca (Postfix, from userid 112) id F06D91E112; Mon, 24 Oct 2022 12:26:44 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=sBpgeISZ; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A55E71E0D3 for ; Mon, 24 Oct 2022 12:26:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 576313858000 for ; Mon, 24 Oct 2022 16:26:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 576313858000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666628804; bh=0cHQUuIgNNZwSmanVSYXKVwlKJxfwFnIjW0BKJZCbOI=; h=To:Subject:In-Reply-To:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=sBpgeISZazg8mXp784PxKMhO1YojL4H6JRXvaDYflvI3VJOdrbeHVPFM7asYBAHiC G+A+6Syu7/hCVnTqYg0kn6CFf6xaB6mkJGWGmYPDJIHulv/J9BnOGU4FNcNzH/EF/H KOq8vu8gN594oeO5GVbkc08ukuCJ/1r7H9zlhgvU= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 117E43858412 for ; Mon, 24 Oct 2022 16:26:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 117E43858412 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-428-UpaKaS1KNEuFFRPZpHaGWw-1; Mon, 24 Oct 2022 12:26:23 -0400 X-MC-Unique: UpaKaS1KNEuFFRPZpHaGWw-1 Received: by mail-qk1-f199.google.com with SMTP id u9-20020a05620a454900b006eeafac8ea4so9356741qkp.19 for ; Mon, 24 Oct 2022 09:26:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0cHQUuIgNNZwSmanVSYXKVwlKJxfwFnIjW0BKJZCbOI=; b=FlH9fbyxOx7DXmp6ZxTk5myinI3NnHcu+7qzX+dQiSGL/KAxhnxOHDw4KDadT3aOVT xLH94dojuxXEj5QEBm0xaTloHHATih5+2tuEPQ13mlBnX7xVQmw5neMy0Lt6qmtm5E5t ZGrq4kFKaQe6yuajqM65vT0l9yv6FQAlyQqij9z8meJ3Fxu8Fk2ODraT6ejV8GGkUry/ RDZxaUvt7ZbcJXgdZArM/TB9ohApGiO8dmGI1JDxz8hjBCZtQD/MiEitntru32YSMCua +XLROovWcC8mfQzJzwxuUUOjeSnZzDGY5xEFRw4rFlKFyHbt5YlSi6OvTsnk+uFipAFN 6KTA== X-Gm-Message-State: ACrzQf1JSQAw4P2G9ACA5CDCH3IU7ZPm2nvN1ARWkZU8ngqv7z9moVh2 siQyVAFzc0L4fOTzQlQdM3sPOQbX39dY0iW/oRlj6/bu2W3sfuDaLhhPi6gV3t2Dc0bFDVwklsv KcK+uknXKuwuSvpaWtoTMBg== X-Received: by 2002:a05:620a:284b:b0:6b4:8685:2aa6 with SMTP id h11-20020a05620a284b00b006b486852aa6mr23976149qkp.780.1666628782850; Mon, 24 Oct 2022 09:26:22 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5JHyxCljGkyFD/Tc+k59+TpmJ/v+t+YNPx4S/r/No4bDOQ9StCPMqCopSUrG8/yI1fzLAPQQ== X-Received: by 2002:a05:620a:284b:b0:6b4:8685:2aa6 with SMTP id h11-20020a05620a284b00b006b486852aa6mr23976137qkp.780.1666628782626; Mon, 24 Oct 2022 09:26:22 -0700 (PDT) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id z4-20020ac86b84000000b0035d432f5ba3sm199201qts.17.2022.10.24.09.26.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 09:26:22 -0700 (PDT) To: Mike Frysinger Subject: Re: [PATCH 05/10] sim/ppc: fix for operator precedence warning from clang In-Reply-To: References: Date: Mon, 24 Oct 2022 17:26:20 +0100 Message-ID: <87a65l89xv.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Mike Frysinger writes: > On 19 Oct 2022 16:24, Andrew Burgess via Gdb-patches wrote: >> --- a/sim/ppc/altivec.igen >> +++ b/sim/ppc/altivec.igen >> @@ -231,7 +231,7 @@ void::model-function::ppc_insn_vr_vscr:itable_index index, model_data *model_ptr >> busy_ptr->vscr_busy = 1; >> >> if (out_vmask) >> - busy_ptr->nr_writebacks = 1 + (PPC_ONE_BIT_SET_P(out_vmask)) ? 1 : 2; >> + busy_ptr->nr_writebacks = 1 + ((PPC_ONE_BIT_SET_P(out_vmask)) ? 1 : 2); > > should drop the paren around PPC_ONE_BIT_SET_P while you're here Pushed with the fix you suggest. Thanks, Andrew