From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uI9bAqDcHmVjqiUAWB0awg (envelope-from ) for ; Thu, 05 Oct 2023 11:56:16 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=dDzmlgas; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 06E161E0C3; Thu, 5 Oct 2023 11:56:16 -0400 (EDT) Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EF61A1E028 for ; Thu, 5 Oct 2023 11:56:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 80FF0385773C for ; Thu, 5 Oct 2023 15:56:13 +0000 (GMT) Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id 3DC423858C52 for ; Thu, 5 Oct 2023 15:55:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3DC423858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from eig-obgw-6005a.ext.cloudfilter.net ([10.0.30.201]) by cmsmtp with ESMTP id oNnpqcsH3IBlVoQhGqMcS8; Thu, 05 Oct 2023 15:55:30 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id oQhgq6MeUnteQoQhgq2REg; Thu, 05 Oct 2023 15:55:56 +0000 X-Authority-Analysis: v=2.4 cv=W8Ir6Dak c=1 sm=1 tr=0 ts=651edc8c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=bhdUkHdE2iEA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=Uh3eFhLDzkSd6yP4ZiQA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2rCTy6RX3S6wwxrrjm/pWc2iadpA1bi/A4jnEwfqQHU=; b=dDzmlgasiTNDGSRb8pfjkL2sR2 M8WN59OdrLJHUuiH1rXkZSW/HyOeOEeJQsa0l18GCqsFDJYpDSr6RIoGTl73k1D9pfSOzWvv1ikE6 fXIZYLBiNfS6pIFcgKW+VQ9d/; Received: from 71-211-130-31.hlrn.qwest.net ([71.211.130.31]:58684 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1) (envelope-from ) id 1qoQhf-001bHT-3B; Thu, 05 Oct 2023 09:55:56 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Lancelot SIX , Andrew Burgess , Tom de Vries , Simon Marchi Subject: Re: [PATCH RFC] Require c++17 compiler References: <20231005065449.32643-1-tdevries@suse.de> <20231005103354.5loeki67slszfrcy@hpe6u-23> <87h6n5tfu9.fsf@redhat.com> X-Attribution: Tom Date: Thu, 05 Oct 2023 09:55:55 -0600 In-Reply-To: (Simon Marchi via Gdb-patches's message of "Thu, 5 Oct 2023 10:32:58 -0400") Message-ID: <87a5sxxdv8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.130.31 X-Source-L: No X-Exim-ID: 1qoQhf-001bHT-3B X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-130-31.hlrn.qwest.net (murgatroyd) [71.211.130.31]:58684 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFojjpFmMXzCjhv8S2BKFI9XwQ9ZSlV/PbVk1OiRtFMbQP6SrRf0DyIkxUSGWHGVOkWP/NLgym0jTFHUf3NxCrKvxN+EAlRUcdGR/84rR4T3PIQgYep3 U1WTK4W7QZoyhmbF6UtsVI7cVuAXpp3VQUDZ1Hhg4c+HjiponOr2BF06pPxWdvTF65MAQpBNm2Vvv6PiZwFW9AqQaRLxNl1E3Mc= X-Spam-Status: No, score=-3019.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> On 10/5/23 10:26, Lancelot SIX via Gdb-patches wrote: >> If you take something like gdb::optional for example, it is used quite >> extensively in the codebase, and I don't think it would be easy to >> remove the it in favor of the standard C++ version any time soon. We >> can have gdb::optional be an alias to std::optional, but the codebase >> will still continue to use "gdb::optional" independently of how this >> is implemented. Simon> Wouldn't it be a simple find and replace, gdb::optional to Simon> std::optional? Conveniently, it's the same number of characters, so it Simon> doesn't even affect line-wrapping. I wrote a patch to make gdb_optional.h check __cplusplus and use the C++17 std::optional. I had to comment out some of the test code to get it to compile (warnings about set-but-unused variables), but other than that it seems fine. I'm running the test suite now. Tom