From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aJzqOniMq2foYCsAWB0awg (envelope-from ) for ; Tue, 11 Feb 2025 12:44:24 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MZQIysWb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E1A4C1E105; Tue, 11 Feb 2025 12:44:24 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EB7D61E08E for ; Tue, 11 Feb 2025 12:44:23 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 33A5D3858C52 for ; Tue, 11 Feb 2025 17:44:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 33A5D3858C52 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MZQIysWb Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 4A7193858C60 for ; Tue, 11 Feb 2025 17:43:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4A7193858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4A7193858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739295805; cv=none; b=cM+baIYcKuChUEklYEDERue4+pIiKeN6FMdW3GCx+yEGxfuyBY0830EvHAff3EHAiGGU4E1ZLeNWSoxkVwf3KiKfsiGUM4pVIiQcfvDF3HBD4Wk797gKKX/4wE2XMZuVHIM2jZx3s8LaIag4I2TeWZWueYr/S3MgZ2nLqrKWEq8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739295805; c=relaxed/simple; bh=TNJzeHpklXioST5zfnjWDwI6GPG52DIlD058ABmzXXo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=tjUS2GVd4ixE5+5iTMerIzn29fxCSW7UVYiBjAp7NJH/8GJ81xPMuavbZTLuS+0m5i8wZm6yaudC2tov5BLgYonGoWSTKnG+yBTB3POhWCYQFfCTtAoHKMwog3tG85xpcYBue/hxw1HCBg+IYLkE4tjj8iZ/gySxFwcpkcIPiT8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4A7193858C60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739295805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JH96XiziVgJ44cqfZlhKPSox/i7u6p1Py8zL89gJR1U=; b=MZQIysWbVtVR8ZW3sth65csM2XZAfQUkJhSVFhTc6cLBfEfBpOjJ1fwzrbRtSwxGHdzeLN WdWbdj4AeTqP1z7Kclghsjj6l+PBgTC8nCzbG8VYmxM6Pp9jd7yKW/duLs7QAx+DFFJpJo IF+VgtxufnT75zn+F+O7KXi8yndPABI= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-94-pA4NDI4uNg-pbHrL9KQ0xw-1; Tue, 11 Feb 2025 12:43:23 -0500 X-MC-Unique: pA4NDI4uNg-pbHrL9KQ0xw-1 X-Mimecast-MFC-AGG-ID: pA4NDI4uNg-pbHrL9KQ0xw_1739295803 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-38dc88ed9c0so1862354f8f.1 for ; Tue, 11 Feb 2025 09:43:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739295802; x=1739900602; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JH96XiziVgJ44cqfZlhKPSox/i7u6p1Py8zL89gJR1U=; b=JpXKz3M6TGYL2a0d7j2BccuZBoH8Lx81vbavzOqsgOj+BmbOPorRKVJNPV5jRGi3Se faoDdygek4BrtbksMWTvNDRlRKHHJZWvGugRevSJ/4c3ZQaEbCFH81AbZ+pgM495+Ud0 emnPhWu9Fum5J6t1MU5c87Q1FyWx03C6W2474b0a7emkfUuac5VKOZbrnvoDmY0+uhgF Xk/4fPWXAhE7dz0tFAjoQT2IrEe/vLNMDIIWPIx8nq+K5CI5vyCDK1mdiwHKWW+B8plR 2wOhc5TxnKd5xnIUzOgXzDfndkQqg7diR7Ve0hta1uFywsldJfv/iPzOqlfUKRSzOewX uL6w== X-Forwarded-Encrypted: i=1; AJvYcCVKWOeItHf9vKDocwu2LcIeuSuLcg6l3oaS1CxxRVMppCjRBZk5Zl4OYaeP5EO1Ly8orNXkTFYEeU/KUQ==@sourceware.org X-Gm-Message-State: AOJu0YxSDLsHcYlIO9VkIP7hDKGOT0X+YSRhwBFtMfjp0LVJcfbnacG4 W1OwrKStAyTre8URaDRwO1evlDx1o+NHmGhguRVaAHEUSV6beT8ta9XHBnVCgXVTbLQV1xHNGgc Zu/L/7PQFPC51D9kiad9MVjZWvizjRTX1HWxk/xyu8b+DIb9ADJmNSj91DQo= X-Gm-Gg: ASbGnctgsGk1Xokhk7gk6qCOPQwxhrnEqDuBWQo7HA0Dtwej/vN3X/xLGuZt/D2ewPj i58Tx9MM07IIvum4azec1OIZeNfeIG9l46rPNbTIsObRKZ1BiWYSv/EOI0MZEaNOM24+GgbrL/T 6L9CqvhL2eC4JsJTQ2/kE3wAOB6Zyin0xMVbsI3GnH9b4TA6SupUpO140zKcSfesGq8NZMny03V DJJliEx6S8/C7/L/l9O3/aPcxpou4cnFhQ6CEnujJ8jrtqHM9w0t6pAxyt+NNzSGfyejLH90Ps0 3wVSzX5DceV699TKn269sxB3pElOvw== X-Received: by 2002:a5d:5f47:0:b0:38d:b7ec:c9d8 with SMTP id ffacd0b85a97d-38de41945edmr4335363f8f.28.1739295802542; Tue, 11 Feb 2025 09:43:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IFHlHoh/LXtTFzQrD/9Vl7KgEzkTShFOXTbVj+xTqJHr1QdruuhhKAvh6VPtH6d2cOEFyr8iA== X-Received: by 2002:a5d:5f47:0:b0:38d:b7ec:c9d8 with SMTP id ffacd0b85a97d-38de41945edmr4335340f8f.28.1739295802150; Tue, 11 Feb 2025 09:43:22 -0800 (PST) Received: from localhost (44.226.159.143.dyn.plus.net. [143.159.226.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38dbde0fd0dsm15266645f8f.75.2025.02.11.09.43.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2025 09:43:21 -0800 (PST) From: Andrew Burgess To: Ivan Kokshaysky , "Maciej W. Rozycki" Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH v2] alpha, ld: remove -taso option In-Reply-To: References: Date: Tue, 11 Feb 2025 17:43:21 +0000 Message-ID: <87a5asml6u.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jUzErRYVlWaBDnd1HaBmXpXtKaAJqH5cIyaDu00iBVg_1739295803 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Ivan Kokshaysky writes: > The -taso switch was quite useful 25 years ago for porting 32-bit > code with broken integer-pointer casting. Not anymore. The EF_ALPHA_32BIT > Linux support is going to be dropped in kernel v6.14 [1], NetBSD and OpenBSD > never had it, so there is no point in keeping the -taso option around. > > Also remove alpha special case that uses -taso from gdb.base/dump.exp > in gdb testsuite. For the GDB testsuite change: Approved-By: Andrew Burgess Thanks, Andrew > > [1] https://lore.kernel.org/all/87jzb2tdb7.fsf_-_@email.froward.int.ebiederm.org > > Signed-off-by: Ivan Kokshaysky > --- > Changes in v2, suggested by Maciej W. Rozycki: > - leave the translations alone; > - remove OPTION_TASO from ld/ldlex.h; > - add entries to ld/NEWS and binutils/NEWS. > --- > binutils/NEWS | 3 +++ > gdb/testsuite/gdb.base/dump.exp | 6 ------ > ld/NEWS | 3 +++ > ld/emultempl/alphaelf.em | 31 ------------------------------- > ld/ldlex.h | 1 - > 5 files changed, 6 insertions(+), 38 deletions(-) > > diff --git a/binutils/NEWS b/binutils/NEWS > index f4687e6c2bc..9c1a54c9355 100644 > --- a/binutils/NEWS > +++ b/binutils/NEWS > @@ -1,5 +1,8 @@ > -*- text -*- > > +* Remove the linker -taso option for Alpha target, as Linux/Alpha kernel > + support for 32-bit pointers has been removed. > + > * Support for Nios II targets has been removed except in the readelf utility, > as this architecture has been EOL'ed by Intel. > > diff --git a/gdb/testsuite/gdb.base/dump.exp b/gdb/testsuite/gdb.base/dump.exp > index 58fedb1d36b..54efe51fbaa 100644 > --- a/gdb/testsuite/gdb.base/dump.exp > +++ b/gdb/testsuite/gdb.base/dump.exp > @@ -26,12 +26,6 @@ set endian "auto" > > set formats {binary ihex srec tekhex verilog} > > -if {[istarget "alpha*-*-*"]} { > - # SREC etc cannot handle 64-bit addresses. Force the test > - # program into the low 31 bits of the address space. > - lappend options "ldflags=-Wl,-taso" > -} > - > # Runs the command 'print zero_all ()'. Uses the PRINT_ZERO_ALL_COUNT > # global to ensure the test names are unique. > set print_zero_all_count 0 > diff --git a/ld/NEWS b/ld/NEWS > index aa3d3e83f35..ccdfc56ac84 100644 > --- a/ld/NEWS > +++ b/ld/NEWS > @@ -1,5 +1,8 @@ > -*- text -*- > > +* Remove the linker -taso option for Alpha target, as Linux/Alpha kernel > + support for 32-bit pointers has been removed. > + > * Support for Nios II target has been removed, as this architecture has been > EOL'ed by Intel. > > diff --git a/ld/emultempl/alphaelf.em b/ld/emultempl/alphaelf.em > index 5ae2587a653..995d7f07a7f 100644 > --- a/ld/emultempl/alphaelf.em > +++ b/ld/emultempl/alphaelf.em > @@ -28,14 +28,8 @@ fragment < #include "elf/alpha.h" > #include "elf-bfd.h" > > -static bool limit_32bit; > - > extern bool elf64_alpha_use_secureplt; > > - > -/* Set the start address as in the Tru64 ld. */ > -#define ALPHA_TEXT_START_32BIT 0x12000000 > - > static void > alpha_after_open (void) > { > @@ -73,14 +67,6 @@ static void > alpha_after_parse (void) > { > link_info.relax_pass = 2; > - if (limit_32bit > - && !bfd_link_pic (&link_info) > - && !bfd_link_relocatable (&link_info)) > - lang_section_start (".interp", > - exp_binop ('+', > - exp_intop (ALPHA_TEXT_START_32BIT), > - exp_nameop (SIZEOF_HEADERS, NULL)), > - NULL); > > ldelf_after_parse (); > } > @@ -97,40 +83,24 @@ alpha_before_allocation (void) > && ! RELAXATION_DISABLED_BY_USER) > ENABLE_RELAXATION; > } > - > -static void > -alpha_finish (void) > -{ > - if (limit_32bit) > - elf_elfheader (link_info.output_bfd)->e_flags |= EF_ALPHA_32BIT; > - > - ldelf_finish (); > -} > EOF > > # Define some shell vars to insert bits of code into the standard elf > # parse_args and list_options functions. > # > PARSE_AND_LIST_LONGOPTS=' > - { "taso", no_argument, NULL, OPTION_TASO }, > { "secureplt", no_argument, NULL, OPTION_SECUREPLT }, > { "no-secureplt", no_argument, NULL, OPTION_NO_SECUREPLT }, > ' > > PARSE_AND_LIST_OPTIONS=' > fprintf (file, _("\ > - --taso Load executable in the lower 31-bit addressable\n\ > - virtual address range\n")); > - fprintf (file, _("\ > --secureplt Force PLT in text segment\n")); > fprintf (file, _("\ > --no-secureplt Force PLT in data segment\n")); > ' > > PARSE_AND_LIST_ARGS_CASES=' > - case OPTION_TASO: > - limit_32bit = 1; > - break; > case OPTION_SECUREPLT: > elf64_alpha_use_secureplt = true; > break; > @@ -144,4 +114,3 @@ PARSE_AND_LIST_ARGS_CASES=' > LDEMUL_AFTER_OPEN=alpha_after_open > LDEMUL_AFTER_PARSE=alpha_after_parse > LDEMUL_BEFORE_ALLOCATION=alpha_before_allocation > -LDEMUL_FINISH=alpha_finish > diff --git a/ld/ldlex.h b/ld/ldlex.h > index b8b7d6b6829..999d0defc61 100644 > --- a/ld/ldlex.h > +++ b/ld/ldlex.h > @@ -246,7 +246,6 @@ enum option_values > OPTION_LIBPATH, > OPTION_NOLIBPATH, > /* Used by emultempl/alphaelf.em. */ > - OPTION_TASO, > OPTION_SECUREPLT, > OPTION_NO_SECUREPLT, > /* Used by emultempl/armelf.em. */