From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IKxCI6RTCWj2EQIAWB0awg (envelope-from ) for ; Wed, 23 Apr 2025 16:55:00 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=KoMJRf4z; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 89F6A1E0C3; Wed, 23 Apr 2025 16:55:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 20B521E05C for ; Wed, 23 Apr 2025 16:55:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 56FB63857BAF for ; Wed, 23 Apr 2025 20:54:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 56FB63857BAF Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=KoMJRf4z Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 32FF03857C7F for ; Wed, 23 Apr 2025 20:54:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 32FF03857C7F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 32FF03857C7F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745441669; cv=none; b=l4hYO5k7jebMaphaeFkUKANzyAN7mCecE6TR3LkIJMBA78Yi4LzwIDMEfjL/2iQXd2PPMOORDrm+zE8rWg0BmErcaeE3nPpJ6qe292WQGWgqHea+XQc05Pif57sIDt3t85cIaiRr1N8vb9lDUS9XnRBS5D27uAUV+Zo+Mw/kEyo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745441669; c=relaxed/simple; bh=WRr6hIQuccFCKNVPBco3eyuqnuAA0HJFGt01F5mgWMo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=xCaMz9hFua8f82rMKa5lnFtGR0ZAt+prtV74s3REhER8M+5kFN1HtjTQ2AwJ/tZ/Y2IMjMZBXU2eGgD4J59A+PkFJnW41WneXIVadvxP3PcGQRYvuM3b3bkHXxL0m0M0w+jJ7pKj1dL8p3Bi6rHAOdm8Uy4Hyum/lZGon0Fkx/0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 32FF03857C7F Received: from eig-obgw-5007a.ext.cloudfilter.net ([10.0.29.141]) by cmsmtp with ESMTPS id 7SVyui39jiuzS7h6yuSkGo; Wed, 23 Apr 2025 20:54:28 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 7h6xu5a9179Ii7h6yuDMAG; Wed, 23 Apr 2025 20:54:28 +0000 X-Authority-Analysis: v=2.4 cv=FY0xxo+6 c=1 sm=1 tr=0 ts=68095384 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=XR8D0OoHHMoA:10 a=ItBw4LHWJt0A:10 a=dzWzf_mpAAAA:8 a=tEQXr559IkYAM9deDhAA:9 a=b4DR9a7p2ZdsqdHBznES:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vH6rSZt4hOlmLXYwiJlzpSBMIA5vwsOMjivky1/JSHo=; b=KoMJRf4zK8mrclJ22zjqkguK+B 9mcHLLrNsXVX7Z8s3gJ126Q4sxwk1fst3UmltuJVOMfAHznGTbaRQXQHGj/M4z4P5o9mFHyYFR50/ C9HMKmjtDP7+VUrg1d+91/Jy1; Received: from 97-118-46-156.hlrn.qwest.net ([97.118.46.156]:55170 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1u7h6x-00000001Ao7-22IQ; Wed, 23 Apr 2025 14:54:27 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 03/28] Emit some type declarations in .gdb_index In-Reply-To: (Simon Marchi's message of "Wed, 23 Apr 2025 00:11:36 -0400") References: <20250402-search-in-psyms-v2-0-ea91704487cb@tromey.com> <20250402-search-in-psyms-v2-3-ea91704487cb@tromey.com> <89815abe-5e45-4db4-8554-55db259ca509@simark.ca> <87v7qx7ena.fsf@tromey.com> X-Attribution: Tom Date: Wed, 23 Apr 2025 14:54:26 -0600 Message-ID: <87a586wqd9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.46.156 X-Source-L: No X-Exim-ID: 1u7h6x-00000001Ao7-22IQ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-46-156.hlrn.qwest.net (prentzel) [97.118.46.156]:55170 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHxEufvgk3WKK22n9MQBlCo0s4q62BpIyI/i5iV1cdye1OSBEasOi9ITSWbLUaly6eAr+uAMRiQClUtvOnd1yxiK5hBeg1WKx/oCCFZlxSID+6dAwWSt NdOlTJgCqkh71rntCqIYIqrW/OOo1UoVM/TeyDq+5Kwh67kBQWGqasL8kEHMokYiBjSX8wgg7DN6TSiU1D3oeQKrYuaU+Jnv+HU= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> I think this is clear enough once you know the structure of the code in Simon> this file (which I didn't know beforehand). It doesn't help that I keep Simon> trying to review this series late at night, when my capacity to learn Simon> new things it near zero... No worries. One thought I had is I could add a new #define alias for this constant, then use that through the file. That would provide a spot to write an overview comment. Tom