From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id t43yLvH2dGh0mzQAWB0awg (envelope-from ) for ; Mon, 14 Jul 2025 08:24:17 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NG3rOVOt; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AABA11E11C; Mon, 14 Jul 2025 08:24:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8E4731E089 for ; Mon, 14 Jul 2025 08:24:16 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0595E385841F for ; Mon, 14 Jul 2025 12:24:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0595E385841F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=NG3rOVOt Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 1C6BB3858D37 for ; Mon, 14 Jul 2025 12:21:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1C6BB3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1C6BB3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752495709; cv=none; b=qBE31recv67TfOaMzM3qOFG8usdT+Hm9E95kvAZK/mUbmEFwhfpqORZkcrLSpWSjQ6wrZoK5egbUrLeXcrYmCHpLioDrAAecREjB74MxTauyAE+sI0LmJwRfWIcbf6BcdhtZysLiStAB81edkpOLIldpfxStMgbQglZz5RFLluo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752495709; c=relaxed/simple; bh=SAAd3zvG9h4Z2OSn0U9gZ4tn/PDc3HBRemwt69ORqNg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=k7Z+DCbDSQP1UizisEzXDWJA0TLPI235q06LbuB2A+QFh8WBBWP12DifdddO+NaVJmvvHpmaBwAvzOdBDXeWMM2C01ICOTFk+LbCjhrdev2/Mn/D2IO1uySCi3MRHOfHCAyiPHl98MXTjENc0qEOJEFuEm9RsAfaJACinFWui50= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1C6BB3858D37 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752495708; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PCLg7trlHn7LiE4uXn5YNEYqunafHoLzXxLC6Fwvx0w=; b=NG3rOVOtY7RUiz+K7HMF7ERMlC9eSDDC3H7EsQINWsrDMTRNGjnDfDJ3TVQ75brHgsXZag qckNNHx73nc8IiRZnPZiJ9pbojP6unoqF5+IPm+0644iCEvWNjnm8eKJAZfE9Y7VD/oyYo Id7SDJIdwii97Icf2P1ctyNCo9SmB6g= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-369-GOg-wQU5OTynZnVIu9k2PA-1; Mon, 14 Jul 2025 08:21:47 -0400 X-MC-Unique: GOg-wQU5OTynZnVIu9k2PA-1 X-Mimecast-MFC-AGG-ID: GOg-wQU5OTynZnVIu9k2PA_1752495706 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3af3c860ed7so1876240f8f.1 for ; Mon, 14 Jul 2025 05:21:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752495706; x=1753100506; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PCLg7trlHn7LiE4uXn5YNEYqunafHoLzXxLC6Fwvx0w=; b=PZEfAF5reiuF1TVz8NwOCqVfIa3RDnVa7JMy/JmFkcUlgDraO4UKl6p0XSO9KVwd2Q Kb5VyvzG1PfMHRwC+cJlyvexs6Ppv+vAknEVEACgjyiD4xxtUGgpu1ra+H+EE7qfVb3s GcpDikhjjew7jfzV69fmPDY+jtiD4gJXcSD4KaNrW+aruCAnm0sJhY8jzTDY7M/6yMyR IgEsuY65eLpksCxVix66xHZaezlyOXYiHpy1uWmG7fKMR+2+IisZF5K9a/sYPzm7AGhD g0mmWaNJ7N5fry64Iy9ActvQGeCgGaYsffacGusYEWdLuLIebQBRDSY42CvzbCu9QX2J /SRg== X-Forwarded-Encrypted: i=1; AJvYcCUikNUfG9nV/YsV9cvx3eRKRINjNC+xCfLxjG9PlUnXy2Yu7JCW4sn0PXqlrDVsJBWjpLfi1xwIZQy4Qg==@sourceware.org X-Gm-Message-State: AOJu0YwgJcVZyDOzTZV32DxyqC2a6RsuiSCQNLnaMwNFeLbzh0Bw6k/I +KEB4YcUsI2+5deJe7FLCkIUUIsEkIPnu2iwJwH+BwjWtxNb09Cn+ighair3H+t0gkdRHrXTlVf euXjlprt4ztkGVSqL7u6s0hF45oMF7dHk1BvvKQCowodp3eXkQZbyK1EWyrXnxEo= X-Gm-Gg: ASbGncuORrNVrb5bgOg64cqwvzx5TonAbvMApepUUb84+xe/V579qOlu6rs4Xb0ntPB zmuqjNi1NyhnlLMbEdOaNiUegdlXt116vOti2MMuyK63pT6yRvEvqn7PqgxHAdObml+ufvUceYk qdxiWmLraeQATCNddd752I4lhdgFMuAde4qzxJCYzzvsHN5ELmoXVw9mkH8IaCKE9EO68+I7sEk DHrBPqQXPq26k19PY8/iYUf6KsHiIkFqM8ywD5dVS3lgMoph1OGK6Asf6/aCgezKv/Qhi3MEMFr lnlBrmDQE/Y7xgUfVS4b0C5c5IFmsGhpJddOQ2SmUqa9DUERe7zaUbYRw+OR+q/u X-Received: by 2002:adf:9d82:0:b0:3a4:f5f6:b4ab with SMTP id ffacd0b85a97d-3b5f2dfd6f7mr7625293f8f.30.1752495706423; Mon, 14 Jul 2025 05:21:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFBVERGqAToxfRKX7tRPtmFaMt8Ba8IOZPMdBPeiVm3JaOIu7Qmxddr6jPclqcMgH8TF12zQg== X-Received: by 2002:adf:9d82:0:b0:3a4:f5f6:b4ab with SMTP id ffacd0b85a97d-3b5f2dfd6f7mr7625272f8f.30.1752495705910; Mon, 14 Jul 2025 05:21:45 -0700 (PDT) Received: from localhost (75.226.159.143.dyn.plus.net. [143.159.226.75]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc21fdsm12282740f8f.33.2025.07.14.05.21.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 05:21:45 -0700 (PDT) From: Andrew Burgess To: Christina Schimpe , gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org, luis.machado@arm.com Subject: Re: [PATCH v5 01/12] gdb, testsuite: Extend core_find procedure to save program output. In-Reply-To: <20250628082810.332526-2-christina.schimpe@intel.com> References: <20250628082810.332526-1-christina.schimpe@intel.com> <20250628082810.332526-2-christina.schimpe@intel.com> Date: Mon, 14 Jul 2025 13:21:44 +0100 Message-ID: <87a557m087.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wL0d8Kdgn3YeA3U-ZosU2v3uUEF8U5YHb0vOpV_zI5I_1752495706 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Christina Schimpe writes: > From: Thiago Jung Bauermann > > The change comes from ARM's GCS series: > > [PATCH v3 5/9] GDB, gdbserver: aarch64-linux: Initial Guarded Control Stack support. > > We need it for testing coredmp files, too. So include it in this > patch series. Typo: "corecmp" With that fixed: Approved-By: Andrew Burgess Thanks, Andrew > > Abridged-by: Christina Schimpe > --- > This is the patch mentioned above: > > https://sourceware.org/pipermail/gdb-patches/2025-June/218892.html > > Minus everything except for the change in gdb.exp's corefind procedure. > --- > gdb/testsuite/lib/gdb.exp | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 3f1cd55d727..bb17c4e91a5 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -9352,7 +9352,13 @@ proc remove_core {pid {test ""}} { > } > } > > -proc core_find {binfile {deletefiles {}} {arg ""}} { > +# Runs ${binfile} expecting it to crash and generate a core file. > +# If DELETEFILES is provided, remove these files after running the program. > +# If ARG is provided, pass it as a command line argument to the program. > +# If OUTPUT_FILE is provided, save the program output to it. > +# Returns the name of the core dump, or empty string if not found. > + > +proc core_find {binfile {deletefiles {}} {arg ""} {output_file "/dev/null"}} { > global objdir subdir > > set destcore "$binfile.core" > @@ -9374,7 +9380,7 @@ proc core_find {binfile {deletefiles {}} {arg ""}} { > set found 0 > set coredir [standard_output_file coredir.[getpid]] > file mkdir $coredir > - catch "system \"(cd ${coredir}; ulimit -c unlimited; ${binfile} ${arg}; true) >/dev/null 2>&1\"" > + catch "system \"(cd ${coredir}; ulimit -c unlimited; ${binfile} ${arg}; true) >${output_file} 2>&1\"" > # remote_exec host "${binfile}" > set binfile_basename [file tail $binfile] > foreach i [list \ > -- > 2.43.0