From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 5TVXBz68qGgL0QkAWB0awg (envelope-from ) for ; Fri, 22 Aug 2025 14:51:42 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=oTnE7+IR; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 081E51E023; Fri, 22 Aug 2025 14:51:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3E1EB1E023 for ; Fri, 22 Aug 2025 14:51:41 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BA6A43851A92 for ; Fri, 22 Aug 2025 18:51:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BA6A43851A92 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=oTnE7+IR Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id C2020385840B for ; Fri, 22 Aug 2025 18:51:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C2020385840B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C2020385840B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755888670; cv=none; b=R5uleojmxAReN3pSi/ookMFbRa6O+PMKjJRAzg05JJ7u8a2AXsBOC0OA4hKPSTSykVHYs6Igrg8J3HHqwDueZ/NBzyxc5bmxzItlUXwLk5jfzUwvJtkklVzChw6VXwd0u8pa0WhcAhEAr5r9Cq/WsQ1eCQsZl/7PL9Yr1I+Y5vU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755888670; c=relaxed/simple; bh=a/7/zFT4a4gXJBgO5Jsx2X/8Yz5oqM1Xipt9zfvU8sY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=mtQkDhzrzhsKty+S8QzKmt2lrqLaLMnrDLU/I6OHJADhs9e+HOKJQ/AGbTNZTn1/XljyRucEXB6ahvLo4dZd1w0llCrdKcvUTPJeWHagLnJ00/BSOSpksAYfsIAp5PPCZG7Ev9S4+NCUftdYiiEedcVhqVbR8sZoYiFSBNAXLFw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C2020385840B Received: from eig-obgw-6007b.ext.cloudfilter.net ([10.0.30.166]) by cmsmtp with ESMTPS id pBpOu7D6JuKaFpWr0u3X96; Fri, 22 Aug 2025 18:51:10 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id pWqzuSOcv9jsppWqzuNuTl; Fri, 22 Aug 2025 18:51:09 +0000 X-Authority-Analysis: v=2.4 cv=d8D1yQjE c=1 sm=1 tr=0 ts=68a8bc1d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=2OwXVqhp2XgA:10 a=ItBw4LHWJt0A:10 a=sSyvJ5ozhafRZkfM0LIA:9 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AYKPnFu7hcfsCJ9rydIrhcZyYfLnBOnw/wOyMxCL35I=; b=oTnE7+IR9ahQWHyYxqZOscnOAY xAfrfKbQxbzAqXkkYxlMD7i5K6FQqikNAE8Xy/GtyHmFQINAk2toBi5WEMp3VJKHHWyRc31kwrdQQ s3/UQa8iSTv+sFZgljOOIu1TN; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:57536 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1upWqz-00000004HNl-0Fb4; Fri, 22 Aug 2025 12:51:09 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/5] [gdb] Make addrmap_mutable::insert_empty return bool In-Reply-To: <20250821133114.24091-3-tdevries@suse.de> (Tom de Vries's message of "Thu, 21 Aug 2025 15:31:11 +0200") References: <20250821133114.24091-1-tdevries@suse.de> <20250821133114.24091-3-tdevries@suse.de> X-Attribution: Tom Date: Fri, 22 Aug 2025 12:51:08 -0600 Message-ID: <87a53rkx5v.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1upWqz-00000004HNl-0Fb4 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:57536 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfKtXIK5i2NiMqmcBA9pOkSkXXw5ZiBrY2NLePnVudugXx+38KVe4halPXUb8+2zBgfEq10Z/KM6Lw9k96F30dU485rGaE83GCNMOiPMnJFVWyyszNVmI g+4Jfkk6kYTt0LxVGfoTxHS9rUvcNVt9z7aH1gVGVZTbK/Axo3pC9F3dO8zFYQLp063U8l1spPqirVxgXhpCHjObSts9cK2Shkg= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tom" == Tom de Vries writes: Tom> @@ -234,8 +235,14 @@ addrmap_mutable::set_empty (CORE_ADDR start, CORE_ADDR end_inclusive, Tom> n && addrmap_node_key (n) <= end_inclusive; Tom> n = splay_tree_successor (addrmap_node_key (n))) Tom> { Tom> - if (! addrmap_node_value (n)) Tom> - addrmap_node_set_value (n, obj); Tom> + if (addrmap_node_value (n)) Tom> + { Tom> + /* Already mapped. */ Tom> + full_range = false; Tom> + continue; Tom> + } Tom> + Tom> + addrmap_node_set_value (n, obj); I think using 'else' here would be better than 'continue', since loop short-circuits are harder to understand. Tom