From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /6h2HqCssWgvUQ8AWB0awg (envelope-from ) for ; Fri, 29 Aug 2025 09:35:28 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=VVrsSj/q; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 698D51E043; Fri, 29 Aug 2025 09:35:28 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DE37A1E043 for ; Fri, 29 Aug 2025 09:35:27 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6084C3858409 for ; Fri, 29 Aug 2025 13:35:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6084C3858409 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=VVrsSj/q Received: from omta033.useast.a.cloudfilter.net (omta033.useast.a.cloudfilter.net [44.202.169.32]) by sourceware.org (Postfix) with ESMTPS id 5C0D13858402 for ; Fri, 29 Aug 2025 13:34:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5C0D13858402 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5C0D13858402 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.32 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1756474489; cv=none; b=ZVfIyMkR398EBUNb00HE6qRNExmgCZtXA4fEF59hktge1A+ps+Ly2NEJUE/Uue8b203RqT7J8+j2Oa3n5TtIM/0hLVCXJP5v+mme8Icz+vA27PS02uzLk++2F0PXm7mthHBBvOQ7tMRFFvKtShr6vxZI6I+5RH5F/bzxjVJkhlk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1756474489; c=relaxed/simple; bh=X7/jo21JKSc+IgO2G4Wihk1cv/QpTP/Q63gP5KvhelU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=lSEOnxOnuB/KQ/pzBra1VZTsbGngp9apnlax1Gyxc9bs/bTYD+Ddq+gERCiDDIkb0yH56+K1Lnzkhs3QLgy+qsIOIOJcrGGSyaZxIM/ieKx7vS+w3vbvtgpYuj0z/QlhNCXX261RVGmmh5YS+P0yqLrdObVqD+HHGs/26zYn8gA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5C0D13858402 Received: from eig-obgw-5001b.ext.cloudfilter.net ([10.0.29.181]) by cmsmtp with ESMTPS id rxJguAmS63DNOrzF5uJyAh; Fri, 29 Aug 2025 13:34:11 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id rzF4ueqAogtDgrzF4u6yf6; Fri, 29 Aug 2025 13:34:11 +0000 X-Authority-Analysis: v=2.4 cv=NrbRc9dJ c=1 sm=1 tr=0 ts=68b1ac53 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=2OwXVqhp2XgA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=IVpOHQvsfVJyVktKSTQA:9 a=zZCYzV9kfG8A:10 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AXx+uWg+H8i0ZoTRkvJW3m8sH/cjQqlA/y5gOmewbLE=; b=VVrsSj/qyAGBlhnNcW7E8JsPzH kqoZ0D03eoybSWt0z2gmzXejVJp3kQx0cken0ESxcD8F4s6IJ5NkPo9AyDrU5vQMRRYdIsaVvgWLy 2YUD7am+ousiHyFnlf3Z+EsHE; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:48200 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1urzF3-00000000IVh-1sRs; Fri, 29 Aug 2025 07:34:09 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] gdb/objfiles: make objfile::sections yield references In-Reply-To: <20250828151100.84594-1-simon.marchi@efficios.com> (Simon Marchi's message of "Thu, 28 Aug 2025 11:10:49 -0400") References: <20250828151100.84594-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Fri, 29 Aug 2025 07:34:06 -0600 Message-ID: <87a53iuu9d.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1urzF3-00000000IVh-1sRs X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:48200 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCoVwJdW899hIty1mXMNCPNfC7ypH07RTONcsnhhaaVRbPVoXWviU+7xZcCSqaN3xlIHR30vJ2n8ovfBmKCNYmz7OAI2VBgTPzkXiUptHcndG05k8G2H gGJZEUdMr8Mx4sMSqpwk0vXxKz+HRI+1P3WDNyYT7DtuRci0ZHjiv0Wnqr2wAf2Z0uaIpNRCcb4dFvIdvXpeUfBByOSfE46GcLc= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> A patch later in this series would change objfile::section_iterator to Simon> yield `obj_section &` instead of `obj_section *`. Do it as a Simon> preparatory patch to avoid polluting that subsequent patch. I think it Simon> would make sense on its own anyway. Seems ok. Simon> - typedef section_iterator self_type; Simon> - typedef obj_section *value_type; Simon> + using self_type = section_iterator; Simon> + using reference = obj_section &; I never remember when value_type or reference need to be declared. Is it really correct to remove value_type? Approved-By: Tom Tromey Tom