From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PUSHED] gdb/testsuite: small fix for amd64-extended-prologue-analysis.exp
Date: Mon, 08 Sep 2025 10:31:38 +0100 [thread overview]
Message-ID: <87a535i939.fsf@redhat.com> (raw)
In-Reply-To: <8735dae5139ecf2d3a79508371c9c861fde12c44.1757323506.git.aburgess@redhat.com>
Andrew Burgess <aburgess@redhat.com> writes:
> I noticed I was sometimes getting this failure:
>
> FAIL: gdb.arch/amd64-extended-prologue-analysis.exp: offset \
> initialization: ASM source: gdb_breakpoint: set breakpoint \
> at *0x0000000000401151
>
> The problem was introduced in commit:
>
> commit f9aa48dc545ef511e19f4dfab88a196b820fd2da
> Date: Thu Aug 28 11:50:13 2025 +0000
>
> gdb, amd64: extend the amd64 prologue analyzer to skip register pushes
>
> A gdb_test_multiple exits early when processing the results of a
> 'disassemble' command, without waiting for the prompt to be seen.
> This can leave unhandled output in expect's input buffer, which will
> then throw off the next test.
>
> Update the gdb_test_multiple to wait for the prompt before declaring
> the test passed.
>
> After this I'm no longer seeing the above failure.
>
> There should be no change in what is tested after this commit.
I've also pushed this to the gdb-17-branch.
Thanks,
Andrew
next prev parent reply other threads:[~2025-09-08 9:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-08 9:25 Andrew Burgess
2025-09-08 9:31 ` Andrew Burgess [this message]
2025-09-08 13:48 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a535i939.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox