From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QXW2ApC+wGhYPj4AWB0awg (envelope-from ) for ; Tue, 09 Sep 2025 19:56:00 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=cYRWOgbD; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0417E1E047; Tue, 09 Sep 2025 19:56:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 91E351E047 for ; Tue, 09 Sep 2025 19:55:59 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F13173858C60 for ; Tue, 9 Sep 2025 23:55:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F13173858C60 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=cYRWOgbD Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 660933858D35 for ; Tue, 9 Sep 2025 23:55:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 660933858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 660933858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757462123; cv=none; b=KBgW7epfoNdFRLU8TzHiNJ16aV4wYf0KsDW8RS3tsRF+n0RO2SS31osxDVtUq7HvvsWv0tPvD5yEQPxO6BHYUfLOXTJKmmIjbziSLV4Fh/F+pV4K7kv9inUdgz4ELKgW3ftVmXeBduI6TAaoO2bGp2Wc+80zcCZTpNM8kmCl16Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757462123; c=relaxed/simple; bh=dO+AlKyYsZqosE1PtX+GjdeEnAvYnl1qmXnlPoH7J7k=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=TLyuz98OOjfpDHiEm1kbh21XVwg9uyyuReXd6w7hHbHLibZzNCgQFK8Zn0euEMkfSJklkXhPaFGoiKQ3sfMzuf3Y20jcyXbNhccWyvu6Fwfj3+zYcoJ3t0Wz5Gb5J8275+nMPc+TXTjeLvZWlE7WOQ2TRSWo09/+uP8ySPPXzPs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 660933858D35 Received: from eig-obgw-6007b.ext.cloudfilter.net ([10.0.30.166]) by cmsmtp with ESMTPS id ve9buX7rTv724w8BHuGADz; Tue, 09 Sep 2025 23:55:23 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id w8BGuZM2K6Yd2w8BGuI816; Tue, 09 Sep 2025 23:55:22 +0000 X-Authority-Analysis: v=2.4 cv=MeNsu4/f c=1 sm=1 tr=0 ts=68c0be6a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=yJojWOMRYYMA:10 a=ItBw4LHWJt0A:10 a=PTfPpehwkUL1vbju1_cA:9 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=C40ao5CinjhNoQuQzWfegpy8rW5IapkaDY37+GB+anQ=; b=cYRWOgbDNxbv/017Zuuzt40SZU ZazUrciXqwDfmXH9ZuEIByr+vMq4/v5jBfDEpm5mi/cGc/biqmHUkrbWWflwcN6zFYgmfQWCkwgcH Yb+y+Gz5FZ44NJ6ceEhPsSgn8; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:36450 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uw8BG-00000001Zob-1N1M; Tue, 09 Sep 2025 17:55:22 -0600 From: Tom Tromey To: Tom Tromey Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 3/7] Boolify line-program.c In-Reply-To: <87o6rkh1kk.fsf@tromey.com> (Tom Tromey's message of "Mon, 08 Sep 2025 19:11:39 -0600") References: <20250907-breakpoint-cu-expand-v1-0-dd2beef9d475@tromey.com> <20250907-breakpoint-cu-expand-v1-3-dd2beef9d475@tromey.com> <445303b8-f7e3-47f8-a67b-588ad3a13a6f@simark.ca> <871pogih7j.fsf@tromey.com> <09056576-0c5b-4d55-b016-583e5e05c57e@simark.ca> <87o6rkh1kk.fsf@tromey.com> X-Attribution: Tom Date: Tue, 09 Sep 2025 17:55:21 -0600 Message-ID: <87a533gp06.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1uw8BG-00000001Zob-1N1M X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (prentzel) [97.122.110.68]:36450 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFb0uTqFhpAWVM9RFrGtuEbr+kJp9/xQADFE8xcm3CkSF08urQ5SljDC2mkjU9rirO4E25iJTje+U+lajwMHRMAr4JoRBW4gEXUaU5uiy3Crz+MOTWaK 8AOAXzfRdQcX9+NWPBhTSiBpC+8GdBxaciRpq56PxEUSWVUGvOY1X7gYxsmddRoEzWPjIPy7lQHbVvNkbLlN/XK60uHINrxFdoo= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon> The actual intro comment should be in the header, with the usual Simon> /* See ... */ Simon> in the source file. It looks like the comments diverged a bit, when Simon> that happens I try to pick the best of both. For instance, it looks Simon> like the comment in the header doesn't have the "Return non-zero if..." Simon> part. Tom> I pushed this already but I will look at it again & fix it tomorrow. I looked at this again, and for the function in question (which I think is dwarf_decode_lines), the doc comment is in the header (line-program.h) and the .c file has a "see..." comment. So I don't see an issue. If it's something else let me know. Tom