From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id NlOvDlaeyWis4gYAWB0awg (envelope-from ) for ; Tue, 16 Sep 2025 13:28:54 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=k07IkJRi; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 288931E0BA; Tue, 16 Sep 2025 13:28:54 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5A8851E04C for ; Tue, 16 Sep 2025 13:28:53 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1631D385702B for ; Tue, 16 Sep 2025 17:28:53 +0000 (GMT) Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id CF2AA3858D39 for ; Tue, 16 Sep 2025 17:28:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF2AA3858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CF2AA3858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758043717; cv=none; b=s4sZE+UccYCJdvJRiJHZTFJwvio/N82dk/5yKn8lnCxSvrLuhccupK8MQQPDRDTT94n45MpGyJCPegLB5wEuay/6ppU4IJw3MzdcBP5uxoGZamEHwmCbgKfz7GoXa92mqVSxvAumnw2mpaJiZZqunjk8AvJIogOgOUgVgyJVc9E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758043717; c=relaxed/simple; bh=oh9EZ/MMfVN84+nuw5jqu+adlYevf5NXeCrQ8jhNmmo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WV3hpIZTEvJztN/JbQt5Po85t+v/x4OIHqXiRRScMXXRrOsCgSCTG0jR0ReERqA8ylZo/+zmmUXBqYcaBYSF3WUAOAsCgftkaVyZJAjPeaI6CYGdKzZOfhVY0BpVIK9K/5mdDaxWb1wlgXA64kpOHkNPbebmRRdQANdiw/J942c= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CF2AA3858D39 Authentication-Results: sourceware.org; dkim=policy reason="signing key too small" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=k07IkJRi Received: from eig-obgw-5007b.ext.cloudfilter.net ([10.0.29.167]) by cmsmtp with ESMTPS id yWmeuFnMYaPqLyZToum3HK; Tue, 16 Sep 2025 17:28:36 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id yZTnuZgNsK57byZTnuz5Ue; Tue, 16 Sep 2025 17:28:35 +0000 X-Authority-Analysis: v=2.4 cv=buRMBFai c=1 sm=1 tr=0 ts=68c99e43 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=yJojWOMRYYMA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=cFA1aGTUEJRYTWNjrNcA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7iNr0U+OCPgMiBHFIBGT7Pm7HKRljVcNr6SjeyK1g88=; b=k07IkJRiz59KZo6VlldMwiaoCI bx/YsIO2BKj3nfZAKRV1lmiysFIGBbDmJas8nW3NCoesvEtn0ddjbeTcApXyRfklw+HPVUbBv0CS8 8vf1gqs8MsTb42zZAwZ16EplP; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:45060 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uyZTm-00000001jpV-3ZOM; Tue, 16 Sep 2025 11:28:34 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] gdb: make structured core file mappings processing global In-Reply-To: <77ac5e8b357c0cb36a14529958cb1f0510daa535.1756828929.git.aburgess@redhat.com> (Andrew Burgess's message of "Tue, 2 Sep 2025 17:03:50 +0100") References: <77ac5e8b357c0cb36a14529958cb1f0510daa535.1756828929.git.aburgess@redhat.com> X-Attribution: Tom Date: Tue, 16 Sep 2025 11:28:34 -0600 Message-ID: <87a52ul325.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1uyZTm-00000001jpV-3ZOM X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:45060 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfAhXmnEqZjAs9CvIDCkiYb4H1b55XJ2MfI40hgupc9hW4zOXb8ZDH1n5v9n5EdjTZhZmeV7OdgVvsEbDPvm3AVGY55+Jf99Xjrw85dVwkxKt1OpA5EeM HKqGAtl4ZqfI29U5rMEl6XX4Itm/Y0mjKDbFqw0VnZrJWBWPrGpwY5kB6V6eOUVlY9sF3T1KpTjrCGmCh/Bn9t0Y9wt3vo5WJnk= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> This commit renames 'struct mapped_file' to 'struct core_mapped_file' Andrew> and moves the struct into gdbcore.h. Then a new global function Andrew> gdb_read_core_file_mappings is created into which I move the code to Andrew> build the structured data. Andrew> Then corelow.c is updated to call gdb_read_core_file_mappings. Andrew> This commit does not extend the Python API, that is for the next Andrew> commit. Andrew> There should be no user visible changes after this commit. Looks good to me. Approved-By: Tom Tromey Tom