From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gwvxLuWHF2kXRwIAWB0awg (envelope-from ) for ; Fri, 14 Nov 2025 14:49:57 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=oi+aFCTq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A70981E04C; Fri, 14 Nov 2025 14:49:57 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DE9D01E04C for ; Fri, 14 Nov 2025 14:49:56 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 87801385841F for ; Fri, 14 Nov 2025 19:49:56 +0000 (GMT) Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 99D963858D20 for ; Fri, 14 Nov 2025 19:49:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 99D963858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 99D963858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763149781; cv=none; b=gIcNSulUylfCypoDop75z1Y6BRlc6bBHufWSylQBLKPKUPC6sD49Pi8nTTM/xempKF5ztR+t64sH9wQNzptHZqlUQl9Obv4WkFxnpvp3ruIFPBcbU1DJHqNlBWZGvVdCQ0ZnGY6IutRz6TNwmnUw+5PPsX7P5t864K41CIDQeL4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1763149781; c=relaxed/simple; bh=ZLQLzxC5GDkWEtxzzCVWn4c6Mvz8VwpmYjNUN4ACxg0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=p6yi0mQT0mch9cHia6T1sqZkbV7JV9/6Z6qNumQdUZAD9ASgDPMVcaSE0WCceKmgL/JBrcFXm4g1oGjgFgzNPDEY592N8fi60yFfpHiVgyLDp5+EWswdzrorGI5zQiQioc9I0f4Fb7EsvOZyY94BdE825HRb2QePK99lT5qz7ZU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 99D963858D20 Authentication-Results: sourceware.org; dkim=policy reason="signing key too small" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=oi+aFCTq Received: from eig-obgw-5007b.ext.cloudfilter.net ([10.0.29.167]) by cmsmtp with ESMTPS id JwDTvXhR3VCBNJzngvanpJ; Fri, 14 Nov 2025 19:49:40 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Jznfvri5AFPddJznfvW6qU; Fri, 14 Nov 2025 19:49:40 +0000 X-Authority-Analysis: v=2.4 cv=OphPyz/t c=1 sm=1 tr=0 ts=691787d4 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=6UeiqGixMTsA:10 a=ItBw4LHWJt0A:10 a=7d_E57ReAAAA:8 a=OStpaayhXz2MuuPbxaUA:9 a=jhqOcbufqs7Y1TYCrUUU:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Dtov4f6V6Oikufhp6EAjR67IOXRsQM+sPJkVdBXb3bg=; b=oi+aFCTqL4fv+iAu2Rixgfyzlm ouMjj77IEimUe3oxCptmF15yqp8F8dBMKM7R5qh6Kegypd+In6XhWTo/n0RZuEf9rE8VnGSk2sdFp IMoQLRak3dWCVRAyXNmhJSKGZ; Received: from 97-122-120-205.hlrn.qwest.net ([97.122.120.205]:42532 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vJzne-00000001HDw-2HFC; Fri, 14 Nov 2025 12:49:38 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] gdb: use gdb::unordered_{set,map} at a few places In-Reply-To: <20251113214507.359286-1-simon.marchi@efficios.com> (Simon Marchi's message of "Thu, 13 Nov 2025 16:43:56 -0500") References: <20251113213506.313040-1-simon.marchi@efficios.com> <20251113214507.359286-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Fri, 14 Nov 2025 12:49:36 -0700 Message-ID: <87a50ov1gv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.120.205 X-Source-L: No X-Exim-ID: 1vJzne-00000001HDw-2HFC X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-120-205.hlrn.qwest.net (bapiya) [97.122.120.205]:42532 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfC3aOW0XO6fejglwP59J0VzJrNKS8B2zIzAy2LZug65udnoAsS5GDQmyvOBW6Ky9h2XDbMgPhEIyVKvCRkrf+99gPPGNjDYcWhnWsu5MfYBgOOUIN1uP bWUYrCRp/rT0qKdQWTqV+uw5CJHSGduzcLpcOR8fOEZGwTEBTQcQjyMdIE+ehFcOGLWNfYtCUpTd7Ks8d/QvKNZ6xCNuDDoR+LM= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> New in v2: Simon> - I forgot to actually build-test with all targets enabled, so I was Simon> missing a change in solib-rocm.c. Simon> Use the gdb:: set/map types instead of the std:: ones. I only changed Simon> places in files I can build on my dev machine. Simon> I needed to explicitly default the move constructor and assigment Simon> operator in proc_mem_file. I think this is ok, as nothing takes the Simon> address of a proc_mem_file, requiring it not to move. Simon> I also needed to do it for refcnt_fd, in solib-rocm.c. It's a bit odd Simon> to prevent moving / copying a refcnt_fd, as this struct doesn't directly Simon> hold a resource, but I think I get why it was done. The patch removes DISABLE_COPY_AND_ASSIGN from refcnt_fd, but that seems like it shouldn't be needed -- the map should handle move-only types fine, and I think proc_mem_file is already one such. Simon> struct refcnt_fd Simon> { Simon> - DISABLE_COPY_AND_ASSIGN (refcnt_fd); Simon> refcnt_fd (int fd, int refcnt) : fd (fd), refcnt (refcnt) {} i.e. this change seems unnecessary. Adding DISABLE_COPY_AND_ASSIGN to proc_mem_file isn't really need, since it's handled by scoped_fd, though maybe it's worthwhile for clarity. Tom