Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: "Jan Vraný" <Jan.Vrany@labware.com>
Cc: "tom@tromey.com" <tom@tromey.com>,
	 "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 13/13] gdb: update message in symbol_file_add_with_addrs after changes in readnow_functions
Date: Tue, 02 Dec 2025 11:57:23 -0700	[thread overview]
Message-ID: <87a50090fg.fsf@tromey.com> (raw)
In-Reply-To: <576dde3ff5c99574ff024b6590c255ea356b1a1b.camel@labware.com> ("Jan =?utf-8?Q?Vran=C3=BD=22's?= message of "Tue, 2 Dec 2025 18:48:26 +0000")

>> Also if there are multiple debug readers for an objfile, we could get
>> the "wrong" message here through no fault of the reader itself, if that
>> makes sense.

Jan> I'm lost. In what situation we'd get "wrong" message?

Looking at the code again maybe it's reasonable/ok.
At least if the sequencing issue is fixed.

Tom

  reply	other threads:[~2025-12-02 18:57 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-24 19:55 [PATCH v2 00/13] reimplement readnow_functions Jan Vrany
2025-11-24 19:55 ` [PATCH v2 01/13] gdb: reimplement readnow_functions::search Jan Vrany
2025-12-02 17:25   ` Tom Tromey
2025-11-24 19:55 ` [PATCH v2 02/13] gdb: implement readnow_functions::has_symbols Jan Vrany
2025-11-24 19:55 ` [PATCH v2 03/13] gdb: implement readnow_functions::has_unexpanded_symtabs Jan Vrany
2025-11-24 19:55 ` [PATCH v2 04/13] gdb: implement readnow_functions::find_last_source_symtab Jan Vrany
2025-11-24 19:55 ` [PATCH v2 05/13] gdb: implement readnow_functions::forget_cached_source_info Jan Vrany
2025-11-24 19:55 ` [PATCH v2 06/13] gdb: implement readnow_functions::lookup_global_symbol_language Jan Vrany
2025-11-24 19:55 ` [PATCH v2 07/13] gdb: implement readnow_functions::print_stats Jan Vrany
2025-11-24 19:55 ` [PATCH v2 08/13] gdb: implement readnow_functions::expand_all_symtabs Jan Vrany
2025-11-24 19:55 ` [PATCH v2 09/13] gdb: implement readnow_functions::find_pc_sect_compunit_symtab Jan Vrany
2025-11-24 19:55 ` [PATCH v2 10/13] gdb: implement readnow_functions::map_symbol_filenames Jan Vrany
2025-11-24 19:55 ` [PATCH v2 11/13] gdb: make readnow_functions to inherit from quick_symbol_functions Jan Vrany
2025-11-24 19:55 ` [PATCH v2 12/13] gdb/testsuite: fix few tests after change in readnow_functions Jan Vrany
2025-12-02 17:26   ` Tom Tromey
2025-11-24 19:55 ` [PATCH v2 13/13] gdb: update message in symbol_file_add_with_addrs after changes " Jan Vrany
2025-12-02 17:29   ` Tom Tromey
2025-12-02 18:48     ` Jan Vraný
2025-12-02 18:57       ` Tom Tromey [this message]
2025-12-02 19:03       ` Tom Tromey
2025-12-03 17:46         ` Jan Vraný
2025-12-02 13:39 ` [PATCH v2 00/13] reimplement readnow_functions Jan Vraný

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a50090fg.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=Jan.Vrany@labware.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox