From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kY27OsOxp2mgcxMAWB0awg (envelope-from ) for ; Tue, 03 Mar 2026 23:14:59 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=bUmrJL6j; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id EA3841E0DD; Tue, 03 Mar 2026 23:14:59 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2965D1E08D for ; Tue, 03 Mar 2026 23:14:59 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 99D144BA2E3D for ; Wed, 4 Mar 2026 04:14:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 99D144BA2E3D Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=bUmrJL6j Received: from mail-ua1-x933.google.com (mail-ua1-x933.google.com [IPv6:2607:f8b0:4864:20::933]) by sourceware.org (Postfix) with ESMTPS id D09D64BA2E0E for ; Wed, 4 Mar 2026 04:14:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D09D64BA2E0E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D09D64BA2E0E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::933 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772597672; cv=none; b=rtGH9cYDTdXtMah8KEPAlbPAxAf0mq+10wphqzdTketw7Q8QeF6dT84v0fFcTKQ73NtkoSNLzAavVwtw+oQJkrluhZUoybJsZ45YuJn60PMwM3m0FVbs+z432VL2njzJnjles1n4eXxbIdgADGsvYQWCBdjF3A1sUxqJwFBH5YU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772597672; c=relaxed/simple; bh=5Zdwb8FNQuXIm7hpwd+AZZ8bqvQKL6zijRI2zhBXGSU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=RWU0wV5WXSj70H8mv+Q9yWTvKP7i7cMXvoUl35F7vOen9SlGIqFeOI1fN9SpEVdr/95baKiUzlVX7iTtBELq7nBn71KbWb+di/Zn0yuDZ8xrr1ljiFvGB+kBZWDh+Zdnc9ogYdwGyGTNtFJlNZZWsaCpFCB3H173nSIeTAZKfOU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D09D64BA2E0E Received: by mail-ua1-x933.google.com with SMTP id a1e0cc1a2514c-94ace5d0e39so1902423241.2 for ; Tue, 03 Mar 2026 20:14:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772597672; x=1773202472; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xeuQi7vHTNtpG4AtAab9u07U63bN4bVjceX55HlOmRg=; b=bUmrJL6jS4zZhanpm7qW8rn6VO9diOd3V9CYlTSDb8SHInBUXXSzFb+qbjVbF7bI59 MYxvxYRcR1ZVQU3RCvia5kaCgTQs0GXhD1BishWUjkF+Ntn7asURpcms4Pw6TjfTOMAh h0AT3VuAhAg8a5WmYGtD85FfY8iBsItSY6cifrz7ZpeJb7jvsAIvInTyiz5q+vX8fb14 6LnM6PIFEd5wqgHZUliajvGW9rYf2AuLh0v0MQkMEP2RvSgweYlxhI+9D/2jfE0n6ho0 4Ins2t0pZDKv4X20K9/tCA7Iu8xgm+VrcppMl/0k/CVplg1MkzDcYVHJxvcJaqK3AuMV FWiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772597672; x=1773202472; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xeuQi7vHTNtpG4AtAab9u07U63bN4bVjceX55HlOmRg=; b=G91vHbTabj9/DTkEkoEMR5h9Hg9Nq9gqGBVGdYT7qFDO0JJ5tfi8MOCu/cuvFneRrl QwzJvlQqu5HPj1ri4tOV1t14b7YsFkD/MN5MDCETy3IB/LiZoHwUz4KM9nwrpskprQGb 77THGxTFKAVpH0g3Jh6V1vH3Ch1mbDgDwnIgk6KKh1/7K1ydvH2KQepebdvyt1QaSkHu AU/x4I+Prtw/ctwKmKLEcxpAqKno5s40d3LhREtms0frQdjlBnpod5JkEfw+Y5zRyAP3 a+LVvFgkN0CdqzhKlNWAJxVseN2gs9YiR4/oBZNPEOLzeDgf2z/5Z5qz+rjdKb0TAiz0 SFkQ== X-Gm-Message-State: AOJu0YwSi3/swjZJ+ZuVnR27c2FbXIq8qxGvT37XpTUhrkr9QNqhUkS4 5MpdhseszQ50BWOupagLeGSTyEH6MYLzaseeARh+nowTewloQoqLJPrIg+4MVAU+ghwOniLPnxk yXd2osnO/6A== X-Gm-Gg: ATEYQzzAfZlBYo9NNYrDfyit1HpNi/GAwbb8DRq7vBu5s95Dj64ERFZKfruzWZjToLd +uS6a8+6aDfQ1NayrL5aP5Of2EnC9MXE2x1mE5U40KGnuueXCMg1QntUFiDs78CT1L2U8hIP2P5 I22A6/wHTnK6AfhuY/cO/bTeWJ2AuOkneWe6dTQMIhTE01T1EG/a6Tj9QNKMqK0e0olYBwcuNJi oEW5VpJ2stjT3ssSVKwAmEGboSfRLyCOR5IDN2VmviC6/SXs7TEC+Ng5gN7o6yHxLmLGF5VpE/g G7atjYnSCgGUOWY5Davg8o03lzaR/BSnom+MZn9Hi3rWu1KRUHrXEBs7lvY22Lgk9fzBB+Vd7go zJuV7eQTPEv7r0cGhEe4dDg9Qan55Q9oB6p+B7henAVjXNFikCx8m+1Qo2kQLcCNWe0ysUoAE04 //GR4DV98o2CYfU5UA8rxYoa2o2qoFXQ5tOA== X-Received: by 2002:a05:6102:2ace:b0:5ef:b3fa:c89a with SMTP id ada2fe7eead31-5ffaaf758aemr369228137.32.1772597672204; Tue, 03 Mar 2026 20:14:32 -0800 (PST) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5ffb17786bbsm301485137.5.2026.03.03.20.14.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2026 20:14:31 -0800 (PST) From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Cc: Chris Packham , Luis , Tom Tromey , Simon Marchi , sunilkumar.dora@windriver.com Subject: Re: [PATCH v4 2/6] GDB: Add aarch64-fpmr-linux.h to gdb/arch/ and gdb/nat/ In-Reply-To: <20260303050641.198127-3-thiago.bauermann@linaro.org> (Thiago Jung Bauermann's message of "Tue, 3 Mar 2026 02:06:37 -0300") References: <20260303050641.198127-1-thiago.bauermann@linaro.org> <20260303050641.198127-3-thiago.bauermann@linaro.org> User-Agent: mu4e 1.12.15; emacs 30.2 Date: Wed, 04 Mar 2026 01:14:29 -0300 Message-ID: <87a4wocjtm.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Thiago Jung Bauermann writes: > GDB conditionally defines HWCAP2_FPMR in gdb/arch/aarch64.h, but that's > not the best place for it since it's a Linux-specific definition. > > Add new Linux- and feature-specific headers to contain it, one for > target-dependent code and the other for native code. > > The target-dependant code should use AARCH64_HWCAP2_FPRM in > gdb/arch/aarch64-pauth-linux.h while native code should use HWCAP2_FPRM, > which will hopefully be defined by the system headers but with a backup > definition in gdb/nat/aarch64-pauth-linux.h if it isn't. > > Suggested-by: Luis > Suggested-by: Simon Marchi Fixed locally these typos and pastos pointed out by Simon in the commit message: - s/HWCAP2_FPRM/HWCAP2_FPMR/g - aarch64-pauth-linux.h =E2=86=92 aarch64-fpmr-linux.h > diff --git a/gdb/nat/aarch64-fpmr-linux.h b/gdb/nat/aarch64-fpmr-linux.h > new file mode 100644 > index 000000000000..bb0243a89396 > --- /dev/null > +++ b/gdb/nat/aarch64-fpmr-linux.h > @@ -0,0 +1,28 @@ > +/* Common Linux native definitions for AArch64 FPMR. > + > + Copyright (C) 2025-2026 Free Software Foundation, Inc. > + > + This file is part of GDB. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see .= */ > + > +#ifndef GDB_NAT_AARCH64_FPMR_LINUX_H > +#define GDB_NAT_AARCH64_FPMR_LINUX_H > + > +/* Feature check for Floating Point Mode Register. */ > +#ifndef HWCAP2_FPMR > +#define HWCAP2_FPMR (1ULL << 48) > +#endif /* HWCAP2_FPMR */ > + > +#endif /* GDB_NAT_AARCH64_FPMR_LINUX_H */ As with the previous patch, I locally amended this one to also include : diff --git a/gdb/nat/aarch64-fpmr-linux.h b/gdb/nat/aarch64-fpmr-linux.h index bb0243a89396..9ed651d95059 100644 --- a/gdb/nat/aarch64-fpmr-linux.h +++ b/gdb/nat/aarch64-fpmr-linux.h @@ -20,6 +20,8 @@ #ifndef GDB_NAT_AARCH64_FPMR_LINUX_H #define GDB_NAT_AARCH64_FPMR_LINUX_H =20 +#include + /* Feature check for Floating Point Mode Register. */ #ifndef HWCAP2_FPMR #define HWCAP2_FPMR (1ULL << 48) --=20 Thiago