From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] [gdb/tui] Allow second tui enable if first fails
Date: Fri, 01 May 2026 13:06:44 -0600 [thread overview]
Message-ID: <87a4ujgda3.fsf@tromey.com> (raw)
In-Reply-To: <20260429111325.1600061-4-tdevries@suse.de> (Tom de Vries's message of "Wed, 29 Apr 2026 13:13:25 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> Commit fb23d7ba4a2 ("[gdb/tui] Handle error in tui_enable") handles a
Tom> particular error during tui_enable, but doesn't allow trying to enable TUI
Tom> again.
Tom> I tried to get this to work, but didn't manage because I didn't understand the
Tom> interaction between endwin and the "tui_batch_rendering defer" destructor:
Tom> - first endwin restores the shell terminal mode
Tom> - then the defer destructor calls doupdate, restoring program shell mode.
This is probably just an oversight in tui_batch_rendering and perhaps
the destructor should check some other flag as well before calling doupdate.
Tom
next prev parent reply other threads:[~2026-05-01 19:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 11:13 [PATCH 0/3] " Tom de Vries
2026-04-29 11:13 ` [PATCH 1/3] [gdb/tui] Factor out require_tui_terminal Tom de Vries
2026-04-29 11:13 ` [PATCH 2/3] [gdb/tui] Factor out init_ncurses Tom de Vries
2026-04-29 11:13 ` [PATCH 3/3] [gdb/tui] Allow second tui enable if first fails Tom de Vries
2026-05-01 19:06 ` Tom Tromey [this message]
2026-05-11 10:38 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4ujgda3.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox