From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] [pre-commit] Add check-new-file-license
Date: Wed, 17 Jun 2026 11:45:35 -0600 [thread overview]
Message-ID: <87a4st5adc.fsf@tromey.com> (raw)
In-Reply-To: <20260605141051.881518-1-tdevries@suse.de> (Tom de Vries's message of "Fri, 5 Jun 2026 16:10:51 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> I forgot to add a copyright notice to a file.
Tom> I came across gdb/contrib/license-check-new-files.sh, and ran it out of
Tom> curiosity, and it pointed out the file.
I didn't know about this file. Weird that it has a '.sh' extension.
Tom> Add a pre-commit check check-new-file-license that runs the script.
Tom> The check is only run for new files, because it's fairly slow, about 2 seconds
Tom> for an empty file:
Hmm that really is quite slow. Is it 2 seconds per invocation or per
new file?
Also the script seems to run git but I wonder if that's even necessary
in this setup.
Tom
next prev parent reply other threads:[~2026-06-17 17:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 14:10 Tom de Vries
2026-06-05 18:06 ` Keith Seitz
2026-06-17 17:45 ` Tom Tromey [this message]
2026-06-17 19:19 ` Tom de Vries
2026-06-18 12:59 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4st5adc.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox