From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/Windows: Make windows-nat skip iterating GPU threads
Date: Fri, 21 Aug 2026 11:44:17 -0600 [thread overview]
Message-ID: <87a4qfqsge.fsf@tromey.com> (raw)
In-Reply-To: <20260619163813.815335-1-pedro@palves.net> (Pedro Alves's message of "Fri, 19 Jun 2026 17:38:13 +0100")
>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
Pedro> When the AMD GPU dbgapi target is pushed on the stack, the GPU threads
Pedro> are put in the same inferior thread list as the CPU threads.
Pedro> all_windows_threads() returns an iterator that walks all threads that
Pedro> have an inferior whose process_target() returns the Windows target.
Pedro> So it ends up walking GPU threads as well, which is incorrect and
Pedro> leads to crashes inside gdb/windows-nat.c. E.g.:
Seems reasonable to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2026-08-21 17:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-19 16:38 Pedro Alves
2026-08-21 17:44 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a4qfqsge.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox