From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +Tr8GymJkGoFiwcAWB0awg (envelope-from ) for ; Thu, 27 Aug 2026 14:59:53 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PvGNUIS5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6D8651E166; Thu, 27 Aug 2026 14:59:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3B9FD1E033 for ; Thu, 27 Aug 2026 14:59:52 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 32B2E4BA9003 for ; Thu, 27 Aug 2026 18:59:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 32B2E4BA9003 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PvGNUIS5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 1D00A4BA23CB for ; Thu, 27 Aug 2026 18:59:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1D00A4BA23CB Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1D00A4BA23CB Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787857166; cv=none; b=S3+LWnC3c4OwVcmrhhcyX+QJOjrCE9CU/126tnkpR8MrvzzDZhylxrNwCibZ/DOqUFtcDwkDG+6gGppLZo8Au0vsxR5a6mltjjlb0gcNgaKS7bzwwOiuSV2FpCepPqqY2Dcm3TZPatqktDKPKyaoiYORYbzF58CeCazYkQMo2mw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787857166; c=relaxed/simple; bh=rUS3206r43I6ZvjIhfOwag6ziLc1acSfAZWksAtH+UE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=XJqE6IfbcXJCxb/z/7uG88yUWg4G6AK4u3qQaqGQ/frsTi0uFq4XAfHJQq+YsnOfMGTEw+jOGN8tFEbbGhLFI5UXnRXzmTdIwUc0X2fUPls1S30sq6fdRzExz5wTxzQ5ZfF9o2NdE4eT/t5Vg69yP0d1u6gtffdW7kCk3Xx4500= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PvGNUIS5 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1D00A4BA23CB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787857165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Or55KXoonCAbQVb5nedh+OCp/EHcWei6HLt8sqxVPBE=; b=PvGNUIS5rJ25YYpfNHN8fDaif+IG7dw+oWIuzQEVZi3+Gbana255AfAmz/LZzJ3JD2rdI4 9njFKzndXe6ABp8qcsaqe8eSAT1UwNz9c4e3IF/8XMhBQ3TaYpKB/jxPujD/inH56MRN6L XH0nVTK6pvx6+z6M8hR0sV3PUtnZhXM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-116-enaH5zBQMbOc9BWrYa4KIA-1; Thu, 27 Aug 2026 14:59:23 -0400 X-MC-Unique: enaH5zBQMbOc9BWrYa4KIA-1 X-Mimecast-MFC-AGG-ID: enaH5zBQMbOc9BWrYa4KIA_1787857162 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4994d67d0e3so421455e9.2 for ; Thu, 27 Aug 2026 11:59:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787857162; x=1788461962; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Or55KXoonCAbQVb5nedh+OCp/EHcWei6HLt8sqxVPBE=; b=VHWuN91katMnoDzqmBOR0/Nv10FGGPpkDj0pnOolzqvKTG1joJvucfMIqKN6oxEpuu BE+GnBcJkm6xoTeAAJoxMspsFAMco1pI9NNjSMW0KX46pQz0+y0bsT4A/mtq2rH3VUZf sLYyYZPQOCAWh/8uWjSipst7CP2nSgO0O2GIHGkWCcik2C/Pmb1Q4CJNHZz/1PeBhBhE VcERrt/fTpK1zD3Hppb9PxOZ+4IotBQEtwuJl5fs4dSTLij5UhFS/1D+uFmeiJmG3opV 2aGSxR6F6vLfsQvhi9tAE0svjDo9UUR96YT4RUFbzViE7hXZU0abV5qzS6R3KlGzPax9 RRLw== X-Forwarded-Encrypted: i=1; AHgh+RpWSfgq8hYgy7FvvSbYuusOQC7B76/KOC1pbztxZyw11MG9jMTayi3rTbdh9vYK5AmJw4pzhLdjyGtZwA==@sourceware.org X-Gm-Message-State: AFuF++mhatXDO/5YejT/NYRP0duzDh0ijc/HhZWkkHBT+GXygSPKWhZm X1jvXh90J4Vns2OHPLxtDOgQpLNqd37uSi1KA0jOyJKvjpdMwTrnzXjpunaaH9MDQcBggFs9Z3y L8ec3dTc+H0GhYJSuFCTLw/w1isnWVVhJeMmcsBjP4WSkJ8NmcoT098uPKHxyMyA= X-Gm-Gg: AR+sD13kRBg8dokKpimWjCnTXGHALVGCIhzeuYdd9pSPXWvzyVdbKo8BnOdix+VgIYD 31IQwuQVdB8EFZNLgI7RJLEpiKY/1iJho3Rgh01jY4sBO1LpC1yIMJTuj8KcqxWWejm6rJpbfLE gFJ4gVGYs3XadnZ+6qseHwfbYGgmRqLISdYOKIxQhsD66YOzzPsWuUUUCdsEuIGMhr5ij42bpTS 6TTS+5JBO79PvSVOWUy1pydjhCaQtGaH2oDHa8c4gwBZM8FgDaN0l1g09egcK39CJaqxFxquj3x lSmUpvLZJA+btmULCBYelFnwCsUIzO0IH4PoAA0tHNNlJuCr0702csFf8b82+0qS1jre+CO3qoy Ow0Zm0hLjrJDsLhCy8HE2FayGVTE= X-Received: by 2002:a05:600c:3145:b0:499:79b9:e220 with SMTP id 5b1f17b1804b1-49b91c44f6cmr12840015e9.10.1787857162277; Thu, 27 Aug 2026 11:59:22 -0700 (PDT) X-Received: by 2002:a05:600c:3145:b0:499:79b9:e220 with SMTP id 5b1f17b1804b1-49b91c44f6cmr12839575e9.10.1787857161754; Thu, 27 Aug 2026 11:59:21 -0700 (PDT) Received: from localhost (128.223.159.143.dyn.plus.net. [143.159.223.128]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49b90f78244sm25687265e9.10.2026.08.27.11.59.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Aug 2026 11:59:21 -0700 (PDT) From: Andrew Burgess To: Rainer Orth Cc: Tom Tromey , gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH] Skip gdb.dap/pauseR.exp on Solaris [PR34548] In-Reply-To: References: <87fr07tupw.fsf@tromey.com> <874igj26tf.fsf@redhat.com> Date: Thu, 27 Aug 2026 19:59:20 +0100 Message-ID: <87a4q7tmnr.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NPyipQ5wqnaQPLMPYBNCYBQMw-rURFlJjEgQ1U66M24_1787857162 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Rainer Orth writes: > Hi Andrew, > >>>> So maybe DAP testing should be entirely disabled for Solaris? >>> >>> Like just returning 0 from allow_dap_tests on Solaris? Or doing so for >>> all targets lacking async support? >> >> I'd suggest adding: >> >> # Return true for targets that support target async, >> # otherwise return false. >> proc supports_target_async {} { >> # ... >> } >> >> then return 0 from allow_dap_tests for any target that returns false >> from the above. That would seem better than just having a selective fix >> in the pause.exp file. > > that certainly makes the most sense. > >>> Here's a breakdown of gdb.dap results on Solaris: >>> >>> 8 ERROR >>> 11 FAIL >>> 713 PASS >>> 8 PATH >>> 8 UNRESOLVED >>> 2 UNSUPPORTED >>> >>> I can't tell if it's still useful this way. >> >> I haven't checked by a lot of these passes are going to be general >> boiler plate stuff. If DAP support is known to require target async > > ... which wasn't completely certain as far as I understood Tom... > >> then my personal feeling is that we'd be better just skipping those >> tests on Solaris. There's plenty of testing done on other targets where >> target async is supported. > > Right: some of them already do their own checks for async support: > > gdb.base/async.exp > gdb.base/bg-exec-sigint-bp-cond.exp > gdb.base/interrupt-noterm.exp > > but in those cases, async commands are a crucial part of the tests and I > couldn't easily use the new supports_target_async there. > > There are certainly others that aren't handled yet. Besides, there are > ca. 400 tests that currently time out on Solaris, massively increasing > make check time ;-( I guess it's a major effort to reduce that number. > >>>> Rainer> This might also be a candidate for the gdb-18 branch. >>>> >>>> It's fine by me. >>> >>> Thanks. I'll way for approval from a release manager then. >> >> It might be worth getting the above changes made first. If you don't >> have time then let me know and I'll take care of it. > > I've now managed to get this working, although it took me some time to > wrap my head around gdb testing procedures. > > Here's what I came up with. The only change on x86-64-pc-linux-gnu was > > +PASS: gdb.testsuite/gdb-caching-proc-consistency.exp: supports_target_async: consistency > > while on Solaris it fully disabled the gdb.dap tests as expected. > > --------------------------------------------------------------------------- > > As detailed in PR PR dap/34548, the gdb.dap/pause.exp test runs > indefinitely on Solaris. To allow make check to finish, it needs to be > terminated manually. > > Since DAP requires asynchronous execution support, this patch checks for > that and disables all gdb.dap tests if missing. > > Tested on x86_64-pc-solaris2.11, sparcv9-sun-solaris2.11, and > x86_64-pc-linux-gnu. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34548 > > -- > ----------------------------------------------------------------------------- > Rainer Orth, Center for Biotechnology, Bielefeld University > > > # HG changeset patch > # Parent 3fcec728f85b5d0cfef637d13368c88dad2e7bbc > Require async support for DAP tests [PR34548] > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -3070,6 +3070,10 @@ gdb_caching_proc with_system_readline {} > } > > gdb_caching_proc allow_dap_tests {} { > + if { ![supports_target_async] } { > + return 0 > + } > + > if { ![allow_python_tests] } { > return 0 > } > @@ -3908,6 +3912,39 @@ gdb_caching_proc supports_memtag {} { > return 0 > } > > +# Return 1 if target supports asynchronous execution, otherwise return 0. > +gdb_caching_proc supports_target_async {} { > + global srcdir subdir gdb_prompt > + > + set me "supports_target_async" > + > + set src { int main() { return 0; } } > + if {![gdb_simple_compile $me $src executable ""]} { > + return 0 > + } > + > + gdb_exit > + gdb_start > + gdb_reinitialize_dir $srcdir/$subdir > + gdb_load $obj > + if { ![runto_main] } { > + return 0 > + } > + > + set res 0 > + gdb_test_multiple "continue &" "" { > + -re "Continuing..*" { > + set res 1 > + } > + -re ".*Asynchronous execution not supported on this target..*" { > + set res 0 > + } > + } > + gdb_exit > + remote_file build delete $obj > + return $res > +} > + > # Return 1 if catch syscall is supported, otherwise return 0. > > gdb_caching_proc supports_catch_syscall {} { Thanks for working on this. Other than Tom's comments, I think this looks fine. I will note that the issues Tom pointed out are present in lots of the other supports_* procs -- not that I expect you to fix them, just noting that lots of this code is a little rough. I'd also ask that you remove these lines from gdb.dap/pause.exp: # PR dap/34548 require {!istarget "*-*-solaris2*"} at the same time as you merge this, as these are no longer needed. Thanks, Andrew