From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id odeXBJtZvmqpsiMAWB0awg (envelope-from ) for ; Thu, 01 Oct 2026 09:01:15 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FHqUCfQu; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0856F1E051; Thu, 01 Oct 2026 09:01:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7F5981E033 for ; Thu, 01 Oct 2026 09:01:14 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7C00F4B920DD for ; Thu, 1 Oct 2026 13:01:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7C00F4B920DD Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FHqUCfQu Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 9A4644B920CE for ; Thu, 1 Oct 2026 12:59:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9A4644B920CE Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9A4644B920CE Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790859582; cv=none; b=Wk5QgL+nVF34PShRFNKeoL9h/qy5fSqYKWeGPGyoQrAKbeJcMBzhXo0CkvgSQ8HhWwDga8i2Ztk+mM+I0uEHuBlvKjU/Ar9Lp3ioS5NsHIObfyICOjgMwt4zRKLFU9jezsZCqPu/Zhj3n+Vbv2ZuuS8LMd6tRnrcMEVwvwlpYj0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790859582; c=relaxed/simple; bh=6w6fKCtjd1hZQSHveYA16N8N4wXq/LvZLWHCRG16ibU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=YD82D6dmAK/O9sKUbTlAtoqFBHrWqTfA8l7NLn6GF4ta4kvfGUseEwBduIzibavQVNNSBQc6PbBTZ3tp2/NzZgC9RiSiLyYWzSyn6clkAQsIKH2LiTTr7hNmr8cBpbhR+bkh+lIrQZP7UoMb5UD/rvotxtfbEgNMLX49umWml50= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FHqUCfQu DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9A4644B920CE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790859581; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=akNQ5/hmHJxvAcFnjLtpnCD0jEfk2kkGqPftyOsFArg=; b=FHqUCfQuUAtqaptDAMZOcy1x4NtjfKiUzPh7AEju/JAaRKmvK75i6N7XLhrQpQ5dty3OJo BUgX3CFKCXBLH8KKI5KA7AADwx0wm56+EJa6UIJ9dO+Uo27PnLGTmmj3ReguatzEDBHQLm 4CZw6Ljj5AhuQKDZj8PtN/zZc9CEZyc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-223-U6qI8eEHOhSP5XhO1f9Z7Q-1; Thu, 01 Oct 2026 08:59:39 -0400 X-MC-Unique: U6qI8eEHOhSP5XhO1f9Z7Q-1 X-Mimecast-MFC-AGG-ID: U6qI8eEHOhSP5XhO1f9Z7Q_1790859578 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4a020cf06c3so4200415e9.3 for ; Thu, 01 Oct 2026 05:59:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790859578; x=1791464378; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=akNQ5/hmHJxvAcFnjLtpnCD0jEfk2kkGqPftyOsFArg=; b=b3uxNusiDrWaPNaMGdkdEj+tCHALyD4GQNDKHqFWYJSg297rrCWt46S82kIU/fFgeJ obb4c8XnYlW5/eaAZ8TADclGCNy46123nQzy9IuNV3Z6nnNhy4uWWNRpTzFKwCe/D0BX 3Dko9qPqrfeH6y4VdKhCkfuBBBd1aOkJWxst2J7NU+VBqOT8NBORZ9blscdL10yv2i0Z drSN2vuA6BBUhFEy+BhLK8tk+jf9x+vO49DximnRCuVydPoYeg/x7EcEN08u1q3vDBNp LYeubybFDkleD9mKV3cKmMTiYu78ut9N+IL0gfFah74h/eaGyQ674xdZvqGS6p4oeA3/ 3eFA== X-Forwarded-Encrypted: i=1; AKwUvBy6ajbJ6LHZkcxxaKL/f4856YnpPyYVWqrxjrYFNF1ZL3umqCRS8QfrfHAR6BzrQaDjGp0Z4CtLXEjZPA==@sourceware.org X-Gm-Message-State: AFuF++m3ts54plWS/oF7ITlSdSeLo7osnRVusrOeLa0RhsHtbp8hIiK1 zDlKd6O8PnteKVCoQ5fAjzxKKlC5nJ9/q3738PIzjAJACAx/nKteRZwD0/KteiALexUzbyBfOff 5JpEjYAKcy50Ip/NAxT0t1AaM3FJcu1W8Z5Xbl9Usp/G7g8h42c1cq40iCrGKNBo= X-Gm-Gg: AYBFou3E5yc3x/5lw+PPzvBsX6+RJxJq01DdHiWvrvxvcIeasVZI1ZH4hlPN+37ZUad aIZO+afzNcZoffBJlJDQ+GpVPGjM3mNUNdYqD1GdHmL7mL9FXs9OzGYT2cvsMESxXbtItml5yT8 hlslo3sXaWHvf7UBqPVh2n449MTM2M3ZxSg5Aqh7ADDd0t60YCD97nL6ZvZbQfRMEhnyfOTu2Cj n/8odUU2h2g/FnQ1c9/73YgTqelaeYgl8IFuN6xdKdGOEBIcm12nLP+qRGpk4uWyDfR2liOl7u6 yNv8QV5Uc0V/IyyQBGFk4hRaSsNMGDM+qAOA0EQKYXZ9+U6TQ5nCNCl6fHG780suUAQptg== X-Received: by 2002:a05:600c:a03:b0:49e:6050:9fbe with SMTP id 5b1f17b1804b1-4a01b001fc6mr79448915e9.15.1790859578324; Thu, 01 Oct 2026 05:59:38 -0700 (PDT) X-Received: by 2002:a05:600c:a03:b0:49e:6050:9fbe with SMTP id 5b1f17b1804b1-4a01b001fc6mr79448565e9.15.1790859577871; Thu, 01 Oct 2026 05:59:37 -0700 (PDT) Received: from localhost ([213.31.44.29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a01f938f89sm60176505e9.9.2026.10.01.05.59.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2026 05:59:37 -0700 (PDT) From: Andrew Burgess To: simon.marchi@polymtl.ca, gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH v2 02/11] gdb: rename some preg/treg variables In-Reply-To: <20261001020952.698419-3-simon.marchi@polymtl.ca> References: <20260929194119.155169-1-simon.marchi@efficios.com> <20261001020952.698419-3-simon.marchi@polymtl.ca> Date: Thu, 01 Oct 2026 13:59:36 +0100 Message-ID: <87a4oxzidj.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: IOU7WQ9O0WV3Sf7SKZuo9iYPniaXFb6MsM4_Wqvr4Fc_1790859578 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org simon.marchi@polymtl.ca writes: > From: Simon Marchi > > global_symbol_searcher and some code around that use "preg" and "treg" as > variable, parameter or field names. Rename to the clearer "name_regex" and > "type_regex". > > I guess that "preg" came from the parameter name of regcomp/regexec, and > treg was derived from that. There are 5 lines that you touch where NULL could be changed to nullptr. I thought we generally made that update whenever we touched a line, but I'll leave it up to you. Approved-By: Andrew Burgess Thanks, Andrew