From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YQXfOIQG2WqHCAgAWB0awg (envelope-from ) for ; Wed, 21 Oct 2026 14:37:56 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=D6hSqKcO; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E3EF61E051; Wed, 21 Oct 2026 14:37:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 376811E04D for ; Wed, 21 Oct 2026 14:37:56 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C39144BA23F4 for ; Wed, 21 Oct 2026 18:37:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C39144BA23F4 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=D6hSqKcO Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 9826C4BA23EC for ; Wed, 21 Oct 2026 18:37:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9826C4BA23EC Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9826C4BA23EC Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792607850; cv=none; b=Gg5e80ggyLD0Fn7dQDX7MZvv1/x3OdaDOUkTGAg2OsAG0CpfxcCPzPurkabebVtBUctvedo3nsgYgni9g+Bt/LREjSYV63ZHemzCk7kv6o04V6LM+158P1R8XNcAY6dCw+01pROz/o/iZ/UIBegzIXAqvBNMHWb90NB7bN4Yh0c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792607850; c=relaxed/simple; bh=gK19B13zQ6FK/vLCmUGxLdypYLzZokJifl9L6cE3RU4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=aaXWv2QP3CdDMhRWwz2BzGbuL14thuMgQdZJmevUqbIiHXYDFppgGp/h3eR5zHnyaPGX/QuFjyiSR8PUnwyUaFyPUfx7BH6Un0NWJACKTNQ6elNJfAlyFfN8IZF9IIMz2ti+M6HxvzWtxW6MY3a8/fRUpX9tLWmckgJGE2CcC+s= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=D6hSqKcO reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9826C4BA23EC Received: from eig-obgw-5003b.ext.cloudfilter.net ([10.0.29.155]) by cmsmtp with ESMTPS id JU39xogBSc3XsJbBpxvaVV; Wed, 21 Oct 2026 18:37:29 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id JbBoxB41pFB8dJbBpxEakX; Wed, 21 Oct 2026 18:37:29 +0000 X-Authority-Analysis: v=2.4 cv=HcoUTjE8 c=1 sm=1 tr=0 ts=6ad90669 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=660iZSQnnn4A:10 a=ItBw4LHWJt0A:10 a=T_Alst9gAAAA:8 a=zstS-IiYAAAA:8 a=MRFrsJu7yx0-WdCprgIA:9 a=DvZ5ixILWSEuw56YIEpp:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Unsubscribe-Post: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HpTT8b4qp7afwChl42/ARo7UCT3u3bpw6BeHOYUFtc0=; b=D6hSqKcOEJkuCjcTQODMcTdOkX 3+FYc0vb97FjUwT+iDR1IoacpZhJYzRo5JzJDrExponIAiRXhzXIzjkrhqLOqAB5X8RmdebowkXqu EWvR2k91jWO+eRsdqBbmpwkEt; Received: from 97-122-110-129.hlrn.qwest.net ([97.122.110.129]:53562 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xJbBo-00000000dEk-1IPA; Wed, 21 Oct 2026 12:37:28 -0600 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 06/27] gdb/testsuite: Don't pass -fPIC on PE/COFF targets In-Reply-To: <20260723130118.206735-7-pedro@palves.net> (Pedro Alves's message of "Thu, 23 Jul 2026 14:00:57 +0100") References: <20260723130118.206735-1-pedro@palves.net> <20260723130118.206735-7-pedro@palves.net> X-Attribution: Tom Date: Wed, 21 Oct 2026 12:37:27 -0600 Message-ID: <87a4o6vr14.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.129 X-Source-L: No X-Exim-ID: 1xJbBo-00000000dEk-1IPA X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-129.hlrn.qwest.net (bapiya) [97.122.110.129]:53562 X-Source-Auth: tom+tromey.com X-Email-Count: 36 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfAdHoq0dimDrm1OaDzvvnorkj+fuj1FRxMFxhJJ9LWEfxUhSpb90ZoqqoluppNNFHi9pjgi0fvKYyE2Drl0+5ZQe504xInkp9Zt12VO+nNFxQa9tlRiA Tix1G51Xxc2xWeKNOvERNxMhSfsQ9A2ugafYWU3UcNwZ+sH9dkfb/HevGYVpF9/mjqwG/Z/CdSQKKdFp1UTpoz+fkhhkDcQkED0= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Pedro" == Pedro Alves writes: Pedro> Originally, gdb.exp wasn't passing -fPIC on cygwin/mingw, but it Pedro> started doing that with commit 2f4132646d8 ("[gdb/testsuite] Don't Pedro> pass -fPIC to gdb_compile_shlib"). Before that commit, Pedro> gdb_compile_shlib added -fpic on the platforms that need it, but added Pedro> nothing in some cases (cygwin, mingw and pe, and the unknown-compiler Pedro> fallback), and the individual testcases papered over that by passing Pedro> additional_flags=-fPIC unconditionally themselves. That commit moved Pedro> the -fPIC from the testcase calls to gdb_compile_shlib, adding it in Pedro> exactly those previously-empty cases, which is how cygwin and mingw Pedro> ended up being passed -fPIC even though they don't need it. Thanks. Approved-By: Tom Tromey Tom