Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Pedro Alves <palves@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [4/5] implement "info vtable"
Date: Thu, 19 Jul 2012 17:01:00 -0000	[thread overview]
Message-ID: <878vefznvz.fsf@fleche.redhat.com> (raw)
In-Reply-To: <m24np4jdru.fsf@igel.home> (Andreas Schwab's message of "Thu, 19	Jul 2012 11:33:57 +0200")

Andreas> [0]: @0x10014278: 0x10001b0c <A::f()>

Please try the appended.

Tom

b/gdb/testsuite/ChangeLog:
2012-07-19  Tom Tromey  <tromey@redhat.com>

	* gdb.cp/virtfunc.exp (make_one_vtable_result): Handle function
	descriptor.
	(test_info_vtbl): Remove unused globals.

diff --git a/gdb/testsuite/gdb.cp/virtfunc.exp b/gdb/testsuite/gdb.cp/virtfunc.exp
index 4621a74..bef71c8 100644
--- a/gdb/testsuite/gdb.cp/virtfunc.exp
+++ b/gdb/testsuite/gdb.cp/virtfunc.exp
@@ -235,7 +235,9 @@ proc make_one_vtable_result {name args} {
     set result "vtable for '${name}' @ $hex .subobject @ $hex.:$nls"
     set count 0
     foreach func $args {
-	append result ".${count}.: $hex <$func..>${nls}"
+	# The (@$hex: ) part is because we might see a descriptor
+	# instead.
+	append result ".${count}.: (@$hex: )?$hex <$func..>${nls}"
 	incr count
     }
 
@@ -245,10 +247,6 @@ proc make_one_vtable_result {name args} {
 # Test "info vtbl".
 
 proc test_info_vtbl {} {
-    global hex
-
-    set nls "\[\r\n\]+"
-
     set vt_A [make_one_vtable_result A A::f]
     set vt_B [make_one_vtable_result B B::f]
     set vt_V [make_one_vtable_result V VB::vvb V::vv]


  reply	other threads:[~2012-07-19 17:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-28 21:48 Tom Tromey
2012-02-29 18:20 ` Eli Zaretskii
2012-03-01 14:52 ` Pedro Alves
2012-03-01 17:36   ` Tom Tromey
2012-03-01 20:18     ` Pedro Alves
2012-03-15 15:43   ` Tom Tromey
2012-03-16  8:10     ` Crash regression [Re: [4/5] implement "info vtable"] Jan Kratochvil
2012-03-19 18:13       ` Tom Tromey
2012-07-19  9:34     ` [4/5] implement "info vtable" Andreas Schwab
2012-07-19 17:01       ` Tom Tromey [this message]
2012-07-20  8:33         ` Andreas Schwab
2012-07-20 14:24           ` Tom Tromey
2012-07-20 14:29             ` Andreas Schwab
2012-07-20 16:23               ` Tom Tromey
2012-07-20 17:34                 ` Andreas Schwab
2012-07-20 17:48                   ` Tom Tromey
2012-07-20 18:08                     ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878vefznvz.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox