From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2555 invoked by alias); 23 Aug 2012 15:26:44 -0000 Received: (qmail 2546 invoked by uid 22791); 23 Aug 2012 15:26:44 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS,TW_EG X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 23 Aug 2012 15:26:28 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7NFQSYV013409 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 23 Aug 2012 11:26:28 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7NFQRAp013098 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 23 Aug 2012 11:26:27 -0400 From: Tom Tromey To: Siddhesh Poyarekar Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][h8300, mt, tilegx, xstormy16] Replace unsafe alloca calls with xmalloc References: <20120821190321.0f1b78bc@spoyarek> Date: Thu, 23 Aug 2012 15:26:00 -0000 In-Reply-To: <20120821190321.0f1b78bc@spoyarek> (Siddhesh Poyarekar's message of "Tue, 21 Aug 2012 19:03:21 +0530") Message-ID: <878vd5r5nh.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-08/txt/msg00663.txt.bz2 >>>>> "Siddhesh" == Siddhesh Poyarekar writes: Siddhesh> gdb/ChangeLog: Siddhesh> * h8300-tdep.c (h8300_push_dummy_call): Replace unsafe alloca Siddhesh> with xmalloc/cleanup. Siddhesh> * mt-tdep.c (mt_push_dummy_call): Likewise. Siddhesh> * tilegx-tdep.c (tilegx_push_dummy_call): Likewise. Siddhesh> * xstormy16-tdep.c (xstormy16_push_dummy_call): Likewise. Looks good to me. Tom