From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3437 invoked by alias); 3 Dec 2012 19:48:45 -0000 Received: (qmail 3429 invoked by uid 22791); 3 Dec 2012 19:48:44 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 Dec 2012 19:48:39 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB3JmdAI014681 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 3 Dec 2012 14:48:39 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id qB3Jmctf005697 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 3 Dec 2012 14:48:38 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Subject: Re: RFC: use const struct block * in more places References: <87ehjggpqm.fsf@fleche.redhat.com> Date: Mon, 03 Dec 2012 19:48:00 -0000 In-Reply-To: <87ehjggpqm.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon, 26 Nov 2012 11:53:37 -0700") Message-ID: <878v9ex6g9.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00040.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> Since a block is read-only once it is fully initialized, I think it is Tom> preferable to pass around 'const struct block *' in most places. ... Tom> I plan to commit it in the absence of comments -- I have the vague Tom> feeling that constification is somehow controversial in gdb, but maybe I Tom> am mixing up my controversies. I personally think it is valuable, Tom> especially in gdb, because gdb has a number of "should-be-read-only" Tom> data structures. I'm checking this in now. Tom