Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Jiong Wang <jiwang@tilera.com>,
	gdb-patches@sourceware.org,        Walter Lee <walt@tilera.com>
Subject: Re: [RFC/TileGX 5/6]show registers in columns
Date: Mon, 11 Feb 2013 19:20:00 -0000	[thread overview]
Message-ID: <878v6ur739.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20130208190946.GD17107@adacore.com> (Joel Brobecker's message of	"Fri, 8 Feb 2013 11:09:46 -0800")

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> IMO, if would be better if you used the ui-out routines to display
Joel> the data, rather than fprintf_filtered. But I am not a big specialist
Joel> in this area. Maybe Tom knows better and could help review the
Joel> printing part.

AFAICT, this is only ever called from the CLI and the TUI.
So plain printing is probably ok.
But I also thought Pedro's suggestion was good.

Tom


      parent reply	other threads:[~2013-02-11 19:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-18  9:30 Jiong Wang
2013-01-18 13:50 ` Joel Brobecker
2013-01-18 16:07   ` Jiong Wang
2013-02-08 19:09     ` Joel Brobecker
2013-02-08 21:09       ` Pedro Alves
2013-02-13 14:42         ` Jiong Wang
2013-02-11 19:20       ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878v6ur739.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jiwang@tilera.com \
    --cc=walt@tilera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox