From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11882 invoked by alias); 19 Apr 2013 14:36:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11871 invoked by uid 89); 19 Apr 2013 14:36:35 -0000 X-Spam-SWARE-Status: No, score=-6.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 19 Apr 2013 14:36:35 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3JEaXgL015279 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 19 Apr 2013 10:36:33 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3JEaW5H017952 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 19 Apr 2013 10:36:33 -0400 From: Tom Tromey To: gdb-patches@sourceware.org Subject: [PATCH 15/28] fix bug in gdbpy_initialize_event_generic References: <87ehe638ww.fsf@fleche.redhat.com> Date: Fri, 19 Apr 2013 14:43:00 -0000 In-Reply-To: <87ehe638ww.fsf@fleche.redhat.com> (Tom Tromey's message of "Fri, 19 Apr 2013 08:13:51 -0600") Message-ID: <878v4ezixb.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-04/txt/msg00598.txt.bz2 The checker noticed that gdbpy_initialize_event_generic could do an extra decref of 'type' if PyType_Ready failed. This fixes the bug. * python/py-event.c (gdbpy_initialize_event_generic): Return early if PyType_Ready fails. --- gdb/python/py-event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/python/py-event.c b/gdb/python/py-event.c index afd07fe..72d57cb 100644 --- a/gdb/python/py-event.c +++ b/gdb/python/py-event.c @@ -76,7 +76,7 @@ gdbpy_initialize_event_generic (PyTypeObject *type, char *name) { if (PyType_Ready (type) < 0) - goto fail; + return -1; Py_INCREF (type); if (PyModule_AddObject (gdb_module, name, (PyObject *) type) < 0) -- 1.8.1.4 Tom