From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17554 invoked by alias); 10 Oct 2013 20:13:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17545 invoked by uid 89); 10 Oct 2013 20:13:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Oct 2013 20:13:21 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9AKD7XL022712 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 10 Oct 2013 16:13:09 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9AKD6Im012579 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 10 Oct 2013 16:13:06 -0400 From: Tom Tromey To: Nicolas Blanc Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v16 1/5] New remove-symbol-file command. References: <1381148820-21890-1-git-send-email-nicolas.blanc@intel.com> <1381148820-21890-2-git-send-email-nicolas.blanc@intel.com> Date: Thu, 10 Oct 2013 20:13:00 -0000 In-Reply-To: <1381148820-21890-2-git-send-email-nicolas.blanc@intel.com> (Nicolas Blanc's message of "Mon, 7 Oct 2013 14:26:56 +0200") Message-ID: <878uy06g1a.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-10/txt/msg00367.txt.bz2 >>>>> "Nicolas" == Nicolas Blanc writes: Nicolas> New command for removing symbol files added via Nicolas> the add-symbol-file command. Thanks. A couple of small nits. Nicolas> +int Nicolas> +is_addr_in_objfile (CORE_ADDR addr, const struct objfile *objfile) Nicolas> +{ Nicolas> + struct obj_section *osect; Nicolas> + Nicolas> + if (objfile == NULL) Nicolas> + return 0; Nicolas> + Nicolas> + ALL_OBJFILE_OSECTIONS (objfile, osect) Nicolas> + { Nicolas> + if (obj_section_addr (osect) <= addr Nicolas> + && addr < obj_section_endaddr (osect)) Nicolas> + return 1; I suspect this should also check section_is_mapped first. Nicolas> + if (args == NULL) Nicolas> + error (_("remove-symbol-file FILENAME\nremove-symbol-file -a ADDRESS")); We don't normally use usage-style text for errors. Instead it can just say something along the lines of "remove-symbol-file: no symbol file provided". Nicolas> + if (objf->flags & OBJF_USERLOADED Should have an explicit "!= 0" check here. Nicolas> + && !query (_("Remove symbol table from file \"%s\"? "), objfile_name (objf))) Line too long, should wrap. Tom