From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17122 invoked by alias); 20 Jun 2014 17:45:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17105 invoked by uid 89); 20 Jun 2014 17:45:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 20 Jun 2014 17:45:47 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s5KHjjRB003881 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 20 Jun 2014 13:45:46 -0400 Received: from barimba (ovpn-113-103.phx2.redhat.com [10.3.113.103]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s5KHjik1000807 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Fri, 20 Jun 2014 13:45:45 -0400 From: Tom Tromey To: Pedro Alves Cc: "gdb-patches\@sourceware.org" Subject: Re: [PATCH] x86 Linux watchpoints: Couldn't write debug register: Invalid, argument. References: <1394154640-14053-1-git-send-email-palves@redhat.com> <1394154640-14053-3-git-send-email-palves@redhat.com> <53272CB0.6050101@redhat.com> <532AF3D0.8090904@redhat.com> <20140617191850.GA10997@host2.jankratochvil.net> <20140619134330.GA14567@host2.jankratochvil.net> <53A2FB68.9090500@redhat.com> <53A3164E.4020109@redhat.com> <20140619170029.GA31275@host2.jankratochvil.net> <53A46706.8010601@redhat.com> Date: Fri, 20 Jun 2014 17:45:00 -0000 In-Reply-To: <53A46706.8010601@redhat.com> (Pedro Alves's message of "Fri, 20 Jun 2014 17:53:26 +0100") Message-ID: <878uor8ofr.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-06/txt/msg00776.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> I _still_ had to touch 3 different places with the same code... I'm Pedro> very much looking forward to having all that merged. Yeah. In the meantime perhaps copying the comments into all 3 copies would make it simpler for the eventual merge. I noticed that the comments are not in linux-x86-low.c or i386-linux-nat.c. Tom