Re: [PATCH 3/9] New commands `enable probe' and `disable probe'.

Jose E. Marchesi
2014-09-29T10:26:45Z

Hi Eli, thanks for your review.

> +@kindex enable probes
> +@item enable probes @r{[}@var{provider} @r{[}@var{name} @r{[}@var{objfile}@r{]}@r{]}@r{]}

Is it correct that NAME can be given only if PROVIDER is given, and
OBJFILE can be given only if both NAME and PROVIDER were given?
That's what the nesting of [..] suggests.

Yes, that is correct. The same syntax is used in the `info probes'
command, so I just kept it.

> +Each argument is a regular expression, used to select probes.\n\
> +PROVIDER matches probe provider names.\n\
> +NAME matches the probe names.\n\
> +OBJECT matches the executable or shared library name.\n\
> +If you do not specify any argument then the command will disable\n\
> +all defined probes."), ^^^^^^^^

A copy/paste typo.

Fixed, thanks.