From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128400 invoked by alias); 25 Jul 2015 23:46:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 128391 invoked by uid 89); 25 Jul 2015 23:46:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 25 Jul 2015 23:46:16 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 32ACC383ACB; Sat, 25 Jul 2015 23:46:15 +0000 (UTC) Received: from localhost (unused-10-15-17-51.yyz.redhat.com [10.15.17.51]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6PNkEUn005510 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 25 Jul 2015 19:46:14 -0400 From: Sergio Durigan Junior To: Eli Zaretskii Cc: simon.marchi@ericsson.com, gdb-patches@sourceware.org Subject: Re: [PATCH] Make sure GDB uses a valid shell when starting the inferior and to perform the "shell" command References: <1437761993-18758-1-git-send-email-sergiodj@redhat.com> <55B2850D.6030306@ericsson.com> <87k2tp5q3g.fsf@redhat.com> <838ua52wmp.fsf@gnu.org> <87fv4d5p8l.fsf@redhat.com> <837fpp2uz5.fsf@gnu.org> <55B29B84.5000707@ericsson.com> <8361583e6v.fsf@gnu.org> <87oaj042uz.fsf@redhat.com> <834mks196a.fsf@gnu.org> <87k2to41bj.fsf@redhat.com> <83380c16wo.fsf@gnu.org> X-URL: http://blog.sergiodj.net Date: Sat, 25 Jul 2015 23:46:00 -0000 In-Reply-To: <83380c16wo.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 Jul 2015 20:30:47 +0300") Message-ID: <878ua34x89.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00764.txt.bz2 On Saturday, July 25 2015, Eli Zaretskii wrote: >> From: Sergio Durigan Junior >> Cc: simon.marchi@ericsson.com, gdb-patches@sourceware.org >> Date: Sat, 25 Jul 2015 13:03:12 -0400 >> >> The new section says: >> >> @node Valid Shell >> @subsection Valid Shell >> >> @value{GDBN} considers a @emph{valid shell} a file that: >> >> @enumerate >> @item >> Exists and can be executed by the user. >> >> @item >> Is not the @file{/sbin/nologin} (or @file{/usr/sbin/nologin}) program. >> >> @item >> Is not the @file{/bin/false} program. >> @end enumerate >> >> If any of those conditions are not met, the specified shell is not >> used by @value{GDBN}. >> >> I do not see any difference from what I said above, but if you think >> this text can be improved, or that this text is not needed at all, then >> by all means feel free to ask this. > > The use of "valid" seems to imply much broader goals. Your > description seems to say that "pseudo-shells used to disable logins" > is a better (though longer) terminology. > > Also, I suggest to say "such as the following", so as not to imply > that this is necessarily an exhaustive list. OK, I will make these changes and send a v3. > Finally, is it really OK to lump here the "cannot be executed by the > user" case? Maybe we should error out in that case. I don't think we should error out in this case, since we can fallback to /bin/sh and display a warning (which is what the patch does). Erroring out seems too much for me. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/