From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7141 invoked by alias); 10 Oct 2016 22:40:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7130 invoked by uid 89); 10 Oct 2016 22:40:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=sk:archive, Hx-spam-relays-external:cmgw3, Hx-spam-relays-external:10.0.90.84, H*RU:10.0.90.84 X-HELO: gproxy9-pub.mail.unifiedlayer.com Received: from gproxy9-pub.mail.unifiedlayer.com (HELO gproxy9-pub.mail.unifiedlayer.com) (69.89.20.122) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Mon, 10 Oct 2016 22:40:05 +0000 Received: (qmail 15027 invoked by uid 0); 10 Oct 2016 22:40:03 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy9.mail.unifiedlayer.com with SMTP; 10 Oct 2016 22:40:03 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id tyfz1t00Y2f2jeq01yg2v0; Mon, 10 Oct 2016 16:40:03 -0600 X-Authority-Analysis: v=2.1 cv=KLfJUj1o c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=CH0kA5CcgfcA:10 a=20KFwNOVAAAA:8 a=k1gfzHKJmkMdm5zbqIsA:9 a=tT2KQb7317MA:10 a=e_O65bzb51kRm2y5VmPK:22 Received: from 71-218-192-86.hlrn.qwest.net ([71.218.192.86]:50682 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1btjEl-0005ep-MP; Mon, 10 Oct 2016 16:39:59 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 15/22] Use std::string in macho_symfile_read_all_oso References: <1474949330-4307-1-git-send-email-tom@tromey.com> <1474949330-4307-16-git-send-email-tom@tromey.com> Date: Mon, 10 Oct 2016 22:40:00 -0000 In-Reply-To: (Pedro Alves's message of "Sun, 9 Oct 2016 18:27:59 +0100") Message-ID: <878ttvq14z.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1btjEl-0005ep-MP X-Source-Sender: 71-218-192-86.hlrn.qwest.net (bapiya) [71.218.192.86]:50682 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-10/txt/msg00233.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> + if (strncmp (oso2->name, archive_name.c_str (), pfx_len) != 0) Pedro> Since archive_name is now a std::string, we can use ==/!= for string Pedro> comparison: Pedro> if (archive_name != oso2->name) It isn't entirely clear to me that this is valid, given that the current comparison is using strncmp. Tom