From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64865 invoked by alias); 29 Nov 2016 05:22:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64838 invoked by uid 89); 29 Nov 2016 05:22:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=surprise X-HELO: gproxy4-pub.mail.unifiedlayer.com Received: from gproxy4-pub.mail.unifiedlayer.com (HELO gproxy4-pub.mail.unifiedlayer.com) (69.89.23.142) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Tue, 29 Nov 2016 05:22:37 +0000 Received: (qmail 19091 invoked by uid 0); 29 Nov 2016 05:22:36 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy4.mail.unifiedlayer.com with SMTP; 29 Nov 2016 05:22:36 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id DhNZ1u00o2f2jeq01hNcAu; Mon, 28 Nov 2016 22:22:36 -0700 X-Authority-Analysis: v=2.1 cv=K/+xQUmI c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=L24OOQBejmoA:10 a=zstS-IiYAAAA:8 a=aAwozMbm8bb6hgRhoOEA:9 a=4G6NA9xxw8l3yy4pmD5M:22 Received: from 71-218-195-233.hlrn.qwest.net ([71.218.195.233]:32992 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cBasD-0006hQ-Do; Mon, 28 Nov 2016 22:22:33 -0700 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 7/8] Use unique_xmalloc_ptr in execute_gdb_command References: <1480395946-10924-1-git-send-email-tom@tromey.com> <1480395946-10924-8-git-send-email-tom@tromey.com> Date: Tue, 29 Nov 2016 05:22:00 -0000 In-Reply-To: <1480395946-10924-8-git-send-email-tom@tromey.com> (Tom Tromey's message of "Mon, 28 Nov 2016 22:05:45 -0700") Message-ID: <878ts2yi5m.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cBasD-0006hQ-Do X-Source-Sender: 71-218-195-233.hlrn.qwest.net (bapiya) [71.218.195.233]:32992 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-11/txt/msg00937.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> This replaces a cleanup in execute_gdb_command with an instance of Tom> unique_xmalloc_ptr. std::string was not used because execute_command Tom> and execute_command_to_string don't accept a "const char *" (in fact Tom> the reason for copying the string at all). To my surprise, this patch is broken. I must not have re-run the python tests locally after writing it :( The problem is that prevent_dont_repeat returns a cleanup, which is then left dangling after this patch. I'm looking into a fix. Meanwhile I think the rest of the series can still be considered. Tom