From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44382 invoked by alias); 10 Apr 2017 23:29:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44369 invoked by uid 89); 10 Apr 2017 23:29:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gproxy8.mail.unifiedlayer.com Received: from gproxy8-pub.mail.unifiedlayer.com (HELO gproxy8.mail.unifiedlayer.com) (67.222.33.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Apr 2017 23:29:54 +0000 Received: from cmgw2 (unknown [10.0.90.83]) by gproxy8.mail.unifiedlayer.com (Postfix) with ESMTP id 88BC81AB2E5 for ; Mon, 10 Apr 2017 17:29:54 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id 6nVr1v00G2f2jeq01nVuly; Mon, 10 Apr 2017 17:29:54 -0600 X-Authority-Analysis: v=2.2 cv=LIwWeNe9 c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=AzvcPWV-tVgA:10 a=F9MMjqwk4p-ouxOr2ysA:9 Received: from 75-166-65-226.hlrn.qwest.net ([75.166.65.226]:54388 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cxikp-0006KB-B7; Mon, 10 Apr 2017 17:29:51 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 07/14] Fix up wchar_iterator comment References: <20170408201208.2672-1-tom@tromey.com> <20170408201208.2672-8-tom@tromey.com> <05064d2453aa53bca4b4f966a6ec95db@polymtl.ca> Date: Mon, 10 Apr 2017 23:29:00 -0000 In-Reply-To: <05064d2453aa53bca4b4f966a6ec95db@polymtl.ca> (Simon Marchi's message of "Mon, 10 Apr 2017 00:02:05 -0400") Message-ID: <878tn7zvro.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cxikp-0006KB-B7 X-Source-Sender: 75-166-65-226.hlrn.qwest.net (bapiya) [75.166.65.226]:54388 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2017-04/txt/msg00253.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Well, the part about calling error is still true (well, it's Simon> technically not calling error but perror_with_name). I think it's good Simon> to mention that the constructor can throw an exception. I changed it to: - - This function either returns a new character set iterator, or calls - error. The result can be freed using a cleanup; see - make_cleanup_wchar_iterator. */ + + This constructor can throw on error. */ wchar_iterator (const gdb_byte *input, size_t bytes, const char *charset, size_t width); Tom