From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65522 invoked by alias); 12 May 2018 03:53:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65504 invoked by uid 89); 12 May 2018 03:53:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=U*simon.marchi, sk:simon.m, sk:simonm, H*f:sk:1525901 X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.4.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 12 May 2018 03:53:31 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 4146B400C6472 for ; Fri, 11 May 2018 22:53:30 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id HLb8fFMHlBcCXHLb8fCkyw; Fri, 11 May 2018 22:53:30 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:43952 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fHLb7-002RXX-Tq; Fri, 11 May 2018 22:53:30 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH RFC 4/5] Introduce scoped_mmapped_file References: <1525901216-15031-1-git-send-email-simon.marchi@ericsson.com> <1525901216-15031-5-git-send-email-simon.marchi@ericsson.com> <87y3grz0px.fsf@tromey.com> <1601635db4edc8926dfcf2a82db65c3e@polymtl.ca> Date: Sat, 12 May 2018 15:49:00 -0000 In-Reply-To: <1601635db4edc8926dfcf2a82db65c3e@polymtl.ca> (Simon Marchi's message of "Thu, 10 May 2018 17:10:44 -0400") Message-ID: <878t8p4jif.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fHLb7-002RXX-Tq X-Source-Sender: 97-122-176-117.hlrn.qwest.net (bapiya) [97.122.176.117]:43952 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00316.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> ... however, then I thought perhaps this question could be avoided by >> just initializing m_fd directly, like: >> >> scoped_mmapped_file (const char *filename) >> : m_fd (open (filename, 0, O_RDONLY)) >> >> Then "reset" wouldn't be needed at all. Simon> I can do that, but I am using reset() in the following patch anyway. Oops, I didn't notice that. FWIW I think it's fine to have a reset method. Tom