From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22208 invoked by alias); 17 May 2018 20:37:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21577 invoked by uid 89); 17 May 2018 20:37:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=regset, Hx-languages-length:714, sk:regcach, sk:PTRACE_ X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 May 2018 20:37:58 +0000 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4HKYDaQ029441 for ; Thu, 17 May 2018 16:37:56 -0400 Received: from e18.ny.us.ibm.com (e18.ny.us.ibm.com [129.33.205.208]) by mx0a-001b2d01.pphosted.com with ESMTP id 2j1epannpc-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 17 May 2018 16:37:56 -0400 Received: from localhost by e18.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 17 May 2018 16:37:55 -0400 Received: from b01cxnp23032.gho.pok.ibm.com (9.57.198.27) by e18.ny.us.ibm.com (146.89.104.205) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 17 May 2018 16:37:52 -0400 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w4HKbpGX45875282; Thu, 17 May 2018 20:37:51 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 932B7AE03C; Thu, 17 May 2018 16:39:51 -0400 (EDT) Received: from pedro.localdomain (unknown [9.18.235.153]) by b01ledav005.gho.pok.ibm.com (Postfix) with ESMTP id 68091AE054; Thu, 17 May 2018 16:39:51 -0400 (EDT) Received: by pedro.localdomain (Postfix, from userid 1000) id 8B18B3C03C2; Thu, 17 May 2018 17:37:48 -0300 (-03) From: Pedro Franco de Carvalho To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 5/8] [PowerPC] Fix access to VSCR in linux targets In-Reply-To: <20180516140403.C603FD80322@oc3748833570.ibm.com> References: <20180516140403.C603FD80322@oc3748833570.ibm.com> Date: Thu, 17 May 2018 21:25:00 -0000 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 18051720-0044-0000-0000-00000415FF9F X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009041; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000261; SDB=6.01033765; UDB=6.00528612; IPR=6.00812893; MB=3.00021169; MTD=3.00000008; XFM=3.00000015; UTC=2018-05-17 20:37:53 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18051720-0045-0000-0000-00000848160A Message-Id: <878t8if277.fsf@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-17_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1805170191 X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00389.txt.bz2 Ulrich Weigand writes: > I'm wondering if we shouldn't have the common regcache_collect_regset > routine zero out areas covered by REGCACHE_MAP_SKIP? Then we wouldn't > need this extra routine here. > >> -static const struct regset ppc32_linux_vrregset = { >> - &ppc32_linux_reg_offsets, >> - ppc_supply_vrregset, >> - ppc_collect_vrregset I think this might affect the s390 target: in s390-linux-nat, fill_gregset uses collect_regset on a buffer that has already been filled through ptrace (PTRACE_PEEKUSR_AREA), which is then used to extract pswm, so it relies on collect_regset not changing the buffer on the skipped slots.