From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83622 invoked by alias); 28 Dec 2018 18:55:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83613 invoked by uid 89); 28 Dec 2018 18:55:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:235 X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.55.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Dec 2018 18:55:22 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway20.websitewelcome.com (Postfix) with ESMTP id F0D56400D3D8A for ; Fri, 28 Dec 2018 12:55:20 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cxI0g9KuuiQercxI0gD55V; Fri, 28 Dec 2018 12:55:20 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8Whw/U9rdbLp7ep8EaMCwnD2UbbwW4dClP4/hArTXI0=; b=hXXumLryuv4aDdXQ3MxAnMC8dh lDRft89nC0VI04B7IpZIvyuoM/0E9HcBEVPf94J7dwYfAwDwXIieON5su1+yzLp1pi5sf/yTWCBTX 8NDENntfLeA3eromfMi+6kg1C; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:34088 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gcxI0-000q7L-MQ; Fri, 28 Dec 2018 12:55:20 -0600 From: Tom Tromey To: Joel Brobecker Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 05/16] Add output styles to gdb References: <20181128001435.12703-1-tom@tromey.com> <20181128001435.12703-6-tom@tromey.com> <20181224040748.GH5246@adacore.com> Date: Fri, 28 Dec 2018 18:55:00 -0000 In-Reply-To: <20181224040748.GH5246@adacore.com> (Joel Brobecker's message of "Mon, 24 Dec 2018 08:07:48 +0400") Message-ID: <878t09o50o.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-12/txt/msg00392.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> The patch looks good to me overall. Just a few very minor nits. [...] I've fixed all these. Thanks for the review. Tom