Re: [PATCH] Testsuite: Ensure changing directory does not break the log file

Alan Hayward
2019-02-22T17:10:54Z

> On 22 Feb 2019, at 14:21, Pedro Alves <palves@redhat.com> wrote:
>
> On 02/22/2019 12:36 PM, Alan Hayward wrote:
>> +# Safe version of cd that ensures the log file is not stopped.
>
> This comment seems unclear to me, if you don't consider the email context.
>
> What does it mean to "stop a file", for instance?
>
> How about:
>
> # Override the 'cd' builtin with a version that ensures that the
> # log file keeps pointing at the same file. We need this because
> # unfortunately the path to the log file is recorded using an
> # relative path name, and, we sometimes need to close/reopen the log
> # after changing the current directory. See get_compiler_info.
>

Ok, I’m happy with switching to that. I wanted to keep the comment a
little more generic, but agreed it makes more sense this way.

Alan.