From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18114 invoked by alias); 4 Mar 2019 15:08:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17744 invoked by uid 89); 4 Mar 2019 15:08:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=rgb X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Mar 2019 15:08:49 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 81530C09F6 for ; Mon, 4 Mar 2019 09:08:48 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 0pCyhZ8HF4FKp0pCyhq2Ad; Mon, 04 Mar 2019 09:08:48 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6VrkJdPKoHOYs6jrZpfObcfMv1jRjsddwv0QXk0jVYs=; b=Qd3YiTIfq8RAGuppmsIDR1lSVz bVe8RTCt2/rKgFL0H/VSHKMbchvF+XUkRTtSe9UJZBQR9qwxFys9AyTf1M7/UPd+gElkbPH0eh05C fmfnGv6XucB8RFf46G9KjsSbH; Received: from 75-166-85-218.hlrn.qwest.net ([75.166.85.218]:42594 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h0pCy-002N99-7y; Mon, 04 Mar 2019 09:08:48 -0600 From: Tom Tromey To: Eli Zaretskii Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 00/16] Add styling to the gdb CLI and TUI References: <20181128001435.12703-1-tom@tromey.com> <83k1kxfzwo.fsf@gnu.org> <8736rja4i8.fsf@tromey.com> <83r2brhw8k.fsf@gnu.org> <87h8cmh1wg.fsf@tromey.com> <83va12gz8j.fsf@gnu.org> <87mumeb935.fsf@tromey.com> <83ef7oezh0.fsf@gnu.org> Date: Mon, 04 Mar 2019 15:08:00 -0000 In-Reply-To: <83ef7oezh0.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 03 Mar 2019 17:42:35 +0200") Message-ID: <878sxuad8g.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00032.txt.bz2 >>>>> "Eli" == Eli Zaretskii writes: Eli> Here's a working prototype I'm currently testing. If this Eli> implementation strategy is acceptable, I will post a proper patch Eli> soon. It looks reasonable to me. Eli> + if (fg.is_none ()) Eli> + fgcolor = norm_attr & 15; Eli> + else Eli> + fgcolor = fg_color[fg.get_value () & 15]; get_value is only defined for basic colors; you'll get an assertion here if the color is not basic. For non-basic colors, you can get the rgb values for the color instead via the get_rgb method. Tom