From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4378 invoked by alias); 4 Apr 2019 03:40:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4369 invoked by uid 89); 4 Apr 2019 03:40:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1686 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 Apr 2019 03:40:53 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DF87EC058CC0; Thu, 4 Apr 2019 03:40:51 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id B5F461834B; Thu, 4 Apr 2019 03:40:51 +0000 (UTC) From: Sergio Durigan Junior To: Tom Tromey Cc: Pedro Alves , Simon Marchi , gdb-patches@sourceware.org Subject: Re: [RFC] Sort #includes in gdb References: <87fttfmnpq.fsf@tromey.com> <878sygydob.fsf@tromey.com> <87r2b7viht.fsf@tromey.com> <875zs1csim.fsf@tromey.com> <87bm1s1a98.fsf@tromey.com> <87h8ben803.fsf@redhat.com> <878swqfpw7.fsf@tromey.com> Date: Thu, 04 Apr 2019 03:40:00 -0000 In-Reply-To: <878swqfpw7.fsf@tromey.com> (Tom Tromey's message of "Wed, 03 Apr 2019 20:47:04 -0600") Message-ID: <878swqh1z0.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00067.txt.bz2 On Wednesday, April 03 2019, Tom Tromey wrote: > Sergio> I'm still investigating, but I think the "--branch" option doesn't > Sergio> specify a branch to be tested; rather, it specified a branch where the > Sergio> test should be performed. I.e., you still have to provide a patch. We > Sergio> currently just support testing against origin/master (that's why, on > Sergio> .buildbot/options, we specify the "try_branch" variable as being > Sergio> "origin/master"). > > Yeah, what I did is push my branch, then commit a trivial change and use > "buildbot try --branch origin/users/tromey/...". The problem with that is that BuildBot needs to know which branch to use when comparing builds. If you specify a branch that's not origin/master, then there are no previous results to compare against. Maybe it could work if you created a new branch, waited 1 hour or so (because our BuildBot doesn't fetch directly from sourceware.org; instead, it uses a mirror, so you have to wait until your branch propagates), commited a trivial change, built it, then put the huge patch on top of it, then put another trivial patch on top, and built it again. Not very cool. > I think it's fine to just test & land this patch in pieces. Normally > patches aren't so big. Again, sorry about the limitations of BuildBot. I remember spending a considerable amount of time trying to increase the patch size that's accepted, but unfortunately the change would have to be propagated to every buildslave, which is not feasible. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/