From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52872 invoked by alias); 11 Apr 2019 19:20:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52860 invoked by uid 89); 11 Apr 2019 19:20:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=H*Ad:U*tom X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Apr 2019 19:20:19 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 6DE7A403A03 for ; Thu, 11 Apr 2019 14:20:17 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id EfFBhGGzl2qH7EfFBhd7W9; Thu, 11 Apr 2019 14:20:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=atyNomwk7nJneyRIJ4WHwrA8S5h0V2De30G+3eFK8IA=; b=YchCx+zKya5ZU5763R8/jQBGy4 JNnGhHpco2/XChcY7fuwq2/UrG1R26YHQJi+ZJla/05OAXG+rAF/9qq4IKia4z9uCMtLqT0TOYD7b X/RLFkfNF3z4/+Zj+iXCFigUF; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:42646 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hEfFB-003AbG-4p; Thu, 11 Apr 2019 14:20:17 -0500 From: Tom Tromey To: Eli Zaretskii Cc: Philippe Waroquiers , Tom Tromey , gdb-patches@sourceware.org Subject: Re: Still some style problems with 8.3 branch References: <1553942211.1854.2.camel@skynet.be> <835zrzi0d7.fsf@gnu.org> Date: Thu, 11 Apr 2019 19:20:00 -0000 In-Reply-To: <835zrzi0d7.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 31 Mar 2019 17:28:52 +0300") Message-ID: <878swg8i33.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-04/txt/msg00209.txt.bz2 >>>>> "Eli" == Eli Zaretskii writes: Eli> I don't think it's due to buffering. If I #ifdef away this part near Eli> the end of prompt_for_continue: Eli> /* Restore the current styling. */ Eli> if (can_emit_style_escape (gdb_stdout)) Eli> emit_style_escape (applied_style); Eli> then the problem seems to go away. So I think this style setting is Eli> what causes the problem, probably because applied_style has the wrong Eli> value here? I think this is correct. Certainly applied_style has the wrong value here, since it was reset by the call to emit_style_escape near the top of prompt_for_continue. So, I think a patch to remove these lines is ok. I can do it if you want. Tom