From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84715 invoked by alias); 4 Jun 2019 17:15:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84002 invoked by uid 89); 4 Jun 2019 17:15:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=filters, pre-existing X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.144.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Jun 2019 17:15:22 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway30.websitewelcome.com (Postfix) with ESMTP id D55165C28A for ; Tue, 4 Jun 2019 12:11:23 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id YCy3hEJOLiQerYCy3hndpt; Tue, 04 Jun 2019 12:11:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=o/5JbSb1tpNo2sV3hznkD1UwiNcnxtw3VBUza+K/Cmo=; b=BIuVZqTxBmsiF9/Lo14uwSO++W 3WK67MK/hpb/I4xZK4Q9uY+CgvJGBQniL2I1uPEvQoFFpTjRKea9RZ9ZKA/6J5n9Nxvm0mWLcIpr4 KVCZhveCbLyxyiMvo/b4ixtcl; Received: from 174-29-48-168.hlrn.qwest.net ([174.29.48.168]:34826 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hYCy3-002VCQ-JH; Tue, 04 Jun 2019 12:11:23 -0500 From: Tom Tromey To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Subject: Re: [RFAv2 1/3] Implement 'set print frame-info|frame-arguments presence'. References: <20190511185603.17231-1-philippe.waroquiers@skynet.be> <20190511185603.17231-2-philippe.waroquiers@skynet.be> Date: Tue, 04 Jun 2019 17:15:00 -0000 In-Reply-To: <20190511185603.17231-2-philippe.waroquiers@skynet.be> (Philippe Waroquiers's message of "Sat, 11 May 2019 20:56:01 +0200") Message-ID: <878suhl1hh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-06/txt/msg00067.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: Philippe> New settings allow to better control what frame information is printed. Philippe> 'set print frame-info' allows to override the default frame information Philippe> printed when a GDB command prints a frame. Thanks for the patch. I wanted to mention - in the last series, I noticed that the ChangeLog entries didn't wind up in the commit messages. I think it is a gdb standard to do that, so please make sure it happens for future pushes. I realize this is a bit of a pain, but various people have scripts for automating it, I believe, and so you can pretty much pick one approach that appeals to you. Philippe> + if (args_type == CLI_PRESENCE) Philippe> + { Philippe> + if (args_iter != Py_None) Philippe> + { Philippe> + if (PyIter_Next (args_iter.get ()) != NULL) This causes a memory leak, because PyIter_Next returns a new reference. You can wrap it in a gdbpy_ref<> to avoid this problem. Sometimes I think we just use wrapper functions for the Python API that let us spell out this stuff in the type system. Philippe> + /* Note that this print_what default implies that 'bt' and 'bt no-filters' Philippe> + shows different information, as the default for 'bt no-filters Philippe> + is LOCATION. */ Philippe> + enum print_what print_what = LOC_AND_ADDRESS; Is this a pre-existing bug? It seems like something we should change, since my believe is that "no filters" should produce the same output as the situation where there are actually no filters installed. Tom