From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94902 invoked by alias); 21 Aug 2019 18:10:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94894 invoked by uid 89); 21 Aug 2019 18:10:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Aug 2019 18:10:13 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8995EC08EC0F; Wed, 21 Aug 2019 18:10:12 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 578EF5D9D3; Wed, 21 Aug 2019 18:10:12 +0000 (UTC) From: Sergio Durigan Junior To: Christian Biesinger Cc: Christian Biesinger via gdb-patches Subject: Re: [PATCH 2/3] Factor out the code to do the datadir-relocation for gdbinit References: <20190820221745.147370-1-cbiesinger@google.com> <20190820221745.147370-3-cbiesinger@google.com> <87r25ejv1r.fsf@redhat.com> <87mug2h0lp.fsf@redhat.com> Date: Wed, 21 Aug 2019 18:10:00 -0000 In-Reply-To: (Christian Biesinger's message of "Wed, 21 Aug 2019 13:08:03 -0500") Message-ID: <878srmgzjw.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-08/txt/msg00504.txt.bz2 On Wednesday, August 21 2019, Christian Biesinger wrote: > On Wed, Aug 21, 2019 at 12:47 PM Sergio Durigan Junior > wrote: >> >> On Wednesday, August 21 2019, Christian Biesinger wrote: >> >> > On Wed, Aug 21, 2019 at 12:19 PM Sergio Durigan Junior >> > wrote: >> >> >> >> On Tuesday, August 20 2019, Christian Biesinger via gdb-patches wrote: >> >> >> >> > gdb/ChangeLog: >> >> > >> >> > 2019-08-20 Christian Biesinger >> >> > >> >> > * main.c (relocate_gdbinit_path_maybe_in_datadir): New function. >> >> > (get_init_files): Update. >> >> >> >> I'm afraid you'll need a descriptive commit message :-). >> > >> > Changed to: >> > >> > 2019-08-20 Christian Biesinger >> > >> > * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code >> > out of get_init_files. >> > (get_init_files): Update. >> > >> > (I guess the title of the commit message is not enough?) >> >> Sorry, I should have been more clear. >> >> The changelog entry was fine; I was referring to the actual commit >> message (the text you write before the changelog). I think a very >> simple text should be enough in this case, since it's a refactorization. > > Oh OK, changed to the following: > Factor out the code to do the datadir-relocation for gdbinit > > This simplifies get_init_files and makes it possible to reuse > this code in an upcoming patch for SYSTEM_GDBINIT_DIR. > > gdb/ChangeLog: > > 2019-08-20 Christian Biesinger > > * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code > out of get_init_files. > (get_init_files): Update. > > (I assume it's fine not to resend the full patch, but let me know if > you want me to) That's great, thanks. I can't approve it as I'm not a GM, but this LGTM. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/