Re: [PATCH] Move gdb-dlfcn.[ch] to gdbsupport/

Tom Tromey
2019-08-21T21:50:00Z

>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio> I need to use 'gdb_dlopen' inside 'gdbsupport/', but it's not yet
Sergio> supported there. This commit moves 'gdb-dlfcn.[ch]' to 'gdbsupport/',
Sergio> which makes it available also on gdbserver.

Thanks for doing this.
It seems like a good idea to me.

Sergio> diff --git a/gdb/gdbserver/configure.ac b/gdb/gdbserver/configure.ac
Sergio> index 0009aac9f2..8d91f0d0e8 100644
Sergio> --- a/gdb/gdbserver/configure.ac
Sergio> +++ b/gdb/gdbserver/configure.ac
Sergio> @@ -88,7 +88,8 @@ AC_CHECK_HEADERS(termios.h sys/reg.h string.h dnl
Sergio> proc_service.h sys/procfs.h linux/elf.h dnl
Sergio> fcntl.h signal.h sys/file.h dnl
Sergio> sys/ioctl.h netinet/in.h sys/socket.h netdb.h dnl
Sergio> - netinet/tcp.h arpa/inet.h)
Sergio> + netinet/tcp.h arpa/inet.h dnl
Sergio> + dlfcn.h)

I think it's better to add this check to gdbsupport/common.m4 (and
remove it from gdb's configure.ac).

Tom