From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 98501 invoked by alias); 7 Oct 2019 22:20:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 98482 invoked by uid 89); 7 Oct 2019 22:20:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=U*gdb-patches, gdb-patches@sourceware.org, gdbpatchessourcewareorg, sk:gdb-pat X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.113) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 Oct 2019 22:20:52 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway32.websitewelcome.com (Postfix) with ESMTP id A6F0382755 for ; Mon, 7 Oct 2019 17:19:32 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id HbLoiLf9JBnGaHbLoiUzYy; Mon, 07 Oct 2019 17:19:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=qU5pdufa4RmGTZV2zmR5KrgrrPvrPjY303Z7kuggIAk=; b=QNP4zEcrlVOKvUgYBuvsWWtI38 iK1jxS2qkEEcGCqhDKyWwDUyLITQSqmvi3MoNRLQ14LYrV2Ihvxzogw8U6n1Vn0GniSesLSAvrfZK 1Qk8M83eFqEfdJbE5IFZRijiQ; Received: from [134.6.55.134] (port=3947 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iHbLo-003F3t-81; Mon, 07 Oct 2019 16:19:32 -0600 From: Tom Tromey To: "Christian Biesinger via gdb-patches" Cc: Christian Biesinger Subject: Re: [PATCH] Move declaration of lang_frame_mismatch_warn to header. References: <20191007175734.257671-1-cbiesinger@google.com> Date: Mon, 07 Oct 2019 22:20:00 -0000 In-Reply-To: <20191007175734.257671-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Mon, 7 Oct 2019 12:57:34 -0500") Message-ID: <878spwqjv1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-10/txt/msg00207.txt.bz2 >>>>> "Christian" == Christian Biesinger via gdb-patches writes: Christian> gdb/ChangeLog: Christian> 2019-10-07 Christian Biesinger Christian> * language.c (lang_frame_mismatch_warn): Make const and move Christian> comment... Christian> * language.h (lang_frame_mismatch_warn): ... here. Also add Christian> declaration. Christian> * top.c (lang_frame_mismatch_warn): Remove declaration. Thanks. Maybe it would be better to just have a function to print this message. That would make it easier to gettext-ize. It can be done as-is though by changing it to a const char *, then wrapping the literal in N_(...), and changing the uses to _(...). Tom