Re: [PATCH] Move gdbserver to top level

Tom de Vries
2020-02-09T14:17:30Z

On 09-02-2020 14:59, Tom de Vries wrote:
> On 03-02-2020 22:34, Tom Tromey wrote:
>> I'm going to push it tomorrow or the day after, unless there's some
>> objection.
>
> Hi,
>
> FYI, starting this commit, I'm running into:
> ...
> (gdb) PASS: gdb.multi/multi-target.exp: continue: non-stop=off: set
> remote-exec file in inferior 2
> spawn of --once --multi localhost:2346 failed
> ERROR: tcl error sourcing
> /data/gdb_versions/devel/src/gdb/testsuite/gdb.multi/multi-target.exp.
> ERROR: Timeout waiting for gdbserver response.

Looking at other tests that use gdbserver, I guess this is missing:
...
diff --git a/gdb/testsuite/gdb.multi/multi-target.exp
b/gdb/testsuite/gdb.multi/multi-target.exp
index 3588eb4d76..6c727b5e3b 100644
--- a/gdb/testsuite/gdb.multi/multi-target.exp
+++ b/gdb/testsuite/gdb.multi/multi-target.exp
@@ -17,6 +17,10 @@

load_lib gdbserver-support.exp

+if { [skip_gdbserver_tests] } {
+ return 0
+}
+
standard_testfile

# The plain remote target can't do multiple inferiors.

...

[ It would be nice though if the gdbserver tests will work again, given
that I'm actually building gdbserver. ]

Thanks,
- Tom