Re: [PATCH] Move gdbserver to top level

Luis Machado
2020-02-17T16:57:51Z

On 2/17/20 10:58 AM, Luis Machado wrote:
> Hi Tom,
>
> On 2/14/20 6:14 PM, Tom Tromey wrote:
>>>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:
>>
>>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>> Sergio> I'm attaching a patch that works OK for me here.Â  WDYT?
>>
>> Tom> This one includes that:
>>
>> Tom> https://sourceware.org/ml/gdb-patches/2020-02/msg00426.html
>>
>> Tom> I see that Luis responded.Â  I'll read that and see what's up.
>>
>> I'm going to check it in now.
>>
>> Tom
>>
>
> I ran into the following this morning...
>
> make[2]: Entering directory
> '/home/luis.machado/work/tcwg/build/binutils-gdb-master/gdbserver'
> make[2]: *** No rule to make target '../gnulib/import/libgnu.a', needed
> by 'gdbserver'.Â  Stop.
>
> This was with a build using a configure line containing "--disable-gdb"
> but no "--disable-gdbserver".
>
> Should --disable-gdb also imply --disable-gdbserver? Or should we be
> able to build gdbserver without building gdb (sounds a bit more complex)?

Meanwhile, thanks to Christian, i've confirmed that adding a similar
block to configure.ac, like this one:

# gdb depends on gnulib and gdbsupport, but as nothing else does, only
# include them if gdb is built.
if echo " ${configdirs} " | grep " gdb " > /dev/null 2>&1 ; then
# The Makefile provides the ordering, so it's enough here to add to
# the list.
configdirs="${configdirs} gnulib gdbsupport"
fi

... fixes the problem for gdbserver as well.