Re: [PATCH] Move gdbserver to top level

Sergio Durigan Junior
2020-02-14T03:54:47Z

On Tuesday, February 11 2020, Tom Tromey wrote:

>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio> I wonder why... We build GDB from scratch on every build. Is there
> Sergio> anything special that needs to be done to run the gdbserver tests now?
>
> No, I just neglected to update the gdb test suite to find gdbserver in
> the new spot.
>
> I will send a patch momentarily.

I'm attaching a patch that works OK for me here. WDYT?

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

From 219ed0823fdc0596be2ba79358b2fd22c2d5e333 Mon Sep 17 00:00:00 2001
From: Sergio Durigan Junior <sergiodj@redhat.com>
Date: Thu, 13 Feb 2020 22:51:23 -0500
Subject: [PATCH] Adjust gdb_server_prog to the new gdbserver location

This patch adjusts 'gdb_server_prog' (from
testsuite/boards/gdbserver-base.exp) to point to the new location
where gdbserver lives. This "unbreaks" the
native{,-extended}-gdbserver boards.

gdb/testsuite/ChangeLog:
2020-02-14 Sergio Durigan Junior <sergiodj@redhat.com>

* boards/gdbserver-base.exp: Adjust 'gdb_server_prog'.
---
gdb/testsuite/boards/gdbserver-base.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/boards/gdbserver-base.exp b/gdb/testsuite/boards/gdbserver-base.exp
index 4db834dd84..f27a2fdf91 100644
--- a/gdb/testsuite/boards/gdbserver-base.exp
+++ b/gdb/testsuite/boards/gdbserver-base.exp
@@ -22,7 +22,7 @@ process_multilib_options ""
set_board_info compiler "[find_gcc]"

# Test the copy of gdbserver in the build directory.
-set_board_info gdb_server_prog "[pwd]/../gdbserver/gdbserver"
+set_board_info gdb_server_prog "[pwd]/../../gdbserver/gdbserver"

# gdbserver does not intercept target file operations and perform them
# on the host.
--
2.21.0