From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.47.144]) by sourceware.org (Postfix) with ESMTPS id 171BD381DCE1 for ; Tue, 17 Mar 2020 20:18:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 171BD381DCE1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 9A5EC13215 for ; Tue, 17 Mar 2020 15:18:44 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id EIfkjOuajXVkQEIfkjgObO; Tue, 17 Mar 2020 15:18:44 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Od5TqlCwuLp7v5QrTzptRvkz5zPzscnSheS/FVSQqYE=; b=yi7M99Rd9CUPun7fH+TzIsaoI0 mmwkk/jAAA+hP4EyWeC1u6bb0bznjOWb/AMwKuuCbFPe3/smACcEQhrqdHGcQh2uzdfkImYrohcRV Z9ftaCJ5bOvh6qz65M9oCrhnb; Received: from 97-118-117-21.hlrn.qwest.net ([97.118.117.21]:41722 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jEIfk-001Pbe-B6; Tue, 17 Mar 2020 14:18:44 -0600 From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , Bernd Edlinger , gdb-patches@sourceware.org Subject: Re: [PATCHv2 2/2] gdb: Add support for tracking the DWARF line table is-stmt field References: <87d09c3tmu.fsf@tromey.com> <875zf34086.fsf@tromey.com> <875zf2zvpm.fsf@tromey.com> <20200317185640.GL3317@embecosm.com> X-Attribution: Tom Date: Tue, 17 Mar 2020 14:18:43 -0600 In-Reply-To: <20200317185640.GL3317@embecosm.com> (Andrew Burgess's message of "Tue, 17 Mar 2020 18:56:40 +0000") Message-ID: <878sjyybto.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.117.21 X-Source-L: No X-Exim-ID: 1jEIfk-001Pbe-B6 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-117-21.hlrn.qwest.net (murgatroyd) [97.118.117.21]:41722 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=1.3 required=5.0 tests=DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL autolearn=no autolearn_force=no version=3.4.2 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Mar 2020 20:18:46 -0000 >>>>> "Andrew" == Andrew Burgess writes: Andrew> + /* If the previous entry is for the same line, at the same pc, and Andrew> + is marked as a statement, while we are trying to add a Andrew> + non-statement, then lets just drop this new non-statement. */ I didn't try it yet, but I suspect it won't work, because the readelf output up-thread showed that the 2nd r.h line was not a statement: File name Line number Starting address View Stmt [...] r.h 6 0x80000042 2 x r.h 6 0x80000042 3 Tom